get rid of commitlint

[ofrobots]

We tried this experiment, I am not sure it is successful:
Too onerous. Unfriendly to non-collaborators. Doesn't work well with github squash and rebase workflow.

Opinions @GoogleCloudPlatform/node-team ?

[kjin]

LGTM. We should still follow conventional commits, especially since we've already got the ball rolling... mostly. It should be possible today to write a GitHub integration to enforce this by failing a check if the PR's title doesn't satisfy conventional commits, since squash+merge'd commits take on the title of the PR itself. Enforcing the body is a little different issue... I've emailed GitHub support about whether there's a feature for Squash and Merge to take on the contents of the initial PR description.

So in short, I think we should still enforce this, but at the GitHub integrations level rather than at the git CLI level.

[AdriVanHoudt]

There is https://github.com/conventional-changelog/validate-commit-msg just an fyi

[ofrobots]

@AdriVanHoudt Thanks! The main challenge we saw was that commit hook time validation puts the burden on people trying to contribute to the repo. In reality the commit time message doesn't matter but rather the message we use at squash-and-merge time in GitHub, which does not get validated.

[marionebl]

Sorry to read commitlint did not match your use case. Paul Irish recently started work on https://github.com/paulirish/commitlintbot. Have not tried it myself but it looks as if this could solve the Squash/Merge problem.

---

Edit: I am collecting ideas on how to improve the contributor experience over at https://github.com/marionebl/commitlint/issues/94. Your feedback would be greatly appreciated.

[kjin]

Thanks for pointing us in that direction! Looking at the high level description it seems like this could be very useful to us.

…

On Oct 14, 2017 9:38 AM, "Mario Nebl" ***@***.***> wrote: Sorry to read commitlint did not match your use case. Paul Irish recently started work on https://github.com/paulirish/commitlintbot. Have not tried it myself but it looks as if this could solve the Squash/Merge problem. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#543 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACQZfFf0CUP2H1rTWPPtWm2qNjbnr_0zks5ssONsgaJpZM4PBliU> .