Skip to content

Enable clippy::missing_const_for_fn #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Enable clippy::missing_const_for_fn #1883

merged 2 commits into from
Oct 12, 2024

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Oct 12, 2024

While we're here, remove defensive programming against bug in Layout::from_size_align which is no longer needed on our new MSRV.

Upgrade our MSRV to 1.65 and remove version detection logic prior to
that version.
While we're here, remove defensive programming against bug in
`Layout::from_size_align` which is no longer needed on our new MSRV.
@joshlf joshlf requested a review from jswrenn October 12, 2024 14:39
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.36%. Comparing base (8342c71) to head (ab3a087).

Files with missing lines Patch % Lines
src/error.rs 66.66% 1 Missing ⚠️
src/pointer/ptr.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              0.9    #1883      +/-   ##
==========================================
- Coverage   87.40%   87.36%   -0.05%     
==========================================
  Files          16       16              
  Lines        5996     5974      -22     
==========================================
- Hits         5241     5219      -22     
  Misses        755      755              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from 0.9 to main October 12, 2024 14:51
@joshlf joshlf added this pull request to the merge queue Oct 12, 2024
Merged via the queue into main with commit 2b56c07 Oct 12, 2024
63 checks passed
@joshlf joshlf deleted the msrv-1.65 branch October 12, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants