Skip to content

Commit 3fc533f

Browse files
committed
[ci] Run cargo-semver-checks on all targets
Credit to @memark for landing obi1kenobi/cargo-semver-checks-action#82, which unblocked this! Closes #357
1 parent 6132f9b commit 3fc533f

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -340,11 +340,6 @@ jobs:
340340
# crates.io. We do this in the matrix rather than in its own job so that it
341341
# gets run on different targets. Some of our API is target-specific (e.g.,
342342
# SIMD type impls), and so we need to run on each target.
343-
#
344-
# TODO(https://github.com/obi1kenobi/cargo-semver-checks-action/issues/54):
345-
# Currently we don't actually do anything with `matrix.target`, so we're
346-
# just duplicating work by running this job multiple times, each time
347-
# targetting the host platform.
348343
- name: Check semver compatibility
349344
uses: obi1kenobi/cargo-semver-checks-action@ca26a44cfb670b2078c8f757d06e696a7c3820cf # v2.5
350345
with:
@@ -363,6 +358,7 @@ jobs:
363358
feature-group: only-explicit-features
364359
features: __internal_use_only_features_that_work_on_stable
365360
rust-toolchain: ${{ env.ZC_TOOLCHAIN }}
361+
rust-target: ${{ matrix.target }}
366362
if: matrix.crate == 'zerocopy' && matrix.features == '--features __internal_use_only_features_that_work_on_stable' && matrix.toolchain == 'stable'
367363

368364
# TODO(#453): Doing this as a matrix step is a hack that allows us to depend

0 commit comments

Comments
 (0)