Move NoteIfConstExpr + helpers to separate class and get rid of dynamic casts.

PiperOrigin-RevId: 762037459

Author: richmckeever

xls/dslx/type_system_v2/BUILD

@@ -18,6 +18,46 @@ package(
     licenses = ["notice"],  # Apache 2.0
 )
 
+cc_library(
+    name = "constant_collector",
+    srcs = ["constant_collector.cc"],
+    hdrs = ["constant_collector.h"],
+    deps = [
+        ":evaluator",
+        ":import_utils",
+        ":inference_table",
+        ":inference_table_converter",
+        ":parametric_struct_instantiator",
+        ":type_annotation_utils",
+        ":type_system_tracer",
+        "//xls/common:casts",
+        "//xls/common/status:ret_check",
+        "//xls/common/status:status_macros",
+        "//xls/dslx:constexpr_evaluator",
+        "//xls/dslx:errors",
+        "//xls/dslx:import_data",
+        "//xls/dslx:interp_value",
+        "//xls/dslx:warning_collector",
+        "//xls/dslx/frontend:ast",
+        "//xls/dslx/frontend:ast_cloner",
+        "//xls/dslx/frontend:ast_node",
+        "//xls/dslx/frontend:ast_node_visitor_with_default",
+        "//xls/dslx/frontend:ast_utils",
+        "//xls/dslx/frontend:pos",
+        "//xls/dslx/type_system:deduce_utils",
+        "//xls/dslx/type_system:parametric_env",
+        "//xls/dslx/type_system:type",
+        "//xls/dslx/type_system:type_info",
+        "//xls/dslx/type_system:type_zero_value",
+        "@com_google_absl//absl/log",
+        "@com_google_absl//absl/log:check",
+        "@com_google_absl//absl/status",
+        "@com_google_absl//absl/status:statusor",
+        "@com_google_absl//absl/strings",
+        "@com_google_absl//absl/types:span",
+    ],
+)
+
 cc_library(
     name = "inference_table",
     srcs = ["inference_table.cc"],
@@ -56,6 +96,7 @@ cc_library(
     deps = [
         ":inference_table",
         "//xls/dslx/frontend:ast",
+        "//xls/dslx/type_system:parametric_env",
         "//xls/dslx/type_system:type_info",
         "@com_google_absl//absl/status",
         "@com_google_absl//absl/status:statusor",
@@ -67,6 +108,7 @@ cc_library(
     srcs = ["inference_table_converter_impl.cc"],
     hdrs = ["inference_table_converter_impl.h"],
     deps = [
+        ":constant_collector",
         ":evaluator",
         ":fast_concretizer",
         ":import_utils",
@@ -82,7 +124,6 @@ cc_library(
         ":unify_type_annotations",
         ":validate_concrete_type",
         "//xls/common:casts",
-        "//xls/common/status:ret_check",
         "//xls/common/status:status_macros",
         "//xls/dslx:constexpr_evaluator",
         "//xls/dslx:errors",
@@ -97,11 +138,9 @@ cc_library(
         "//xls/dslx/frontend:builtin_stubs_utils",
         "//xls/dslx/frontend:module",
         "//xls/dslx/frontend:pos",
-        "//xls/dslx/type_system:deduce_utils",
         "//xls/dslx/type_system:parametric_env",
         "//xls/dslx/type_system:type",
         "//xls/dslx/type_system:type_info",
-        "//xls/dslx/type_system:type_zero_value",
         "@com_google_absl//absl/algorithm:container",
         "@com_google_absl//absl/container:flat_hash_map",
         "@com_google_absl//absl/container:flat_hash_set",