Skip to content

Migrate async_html from dart:html to package:web #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

parlough
Copy link
Collaborator

@parlough parlough commented Feb 13, 2025

This migration uses the deprecated HttpRequest helper(s) from package:web so it doesn't need to reimplement any handling. Usages of this HTML client should likely migrate to #314.

Resolves #312

@parlough
Copy link
Collaborator Author

@devoncarew I'm guessing there might not be anyone that maintains this repository. Could you help me find reviewers for this and the other PRs I opened recently? No rush on them though :)

Thanks!

Copy link
Collaborator

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devoncarew
Copy link
Collaborator

@devoncarew I'm guessing there might not be anyone that maintains this repository. Could you help me find reviewers for this and the other PRs I opened recently? No rush on them though :)

I'll take a pass through them and may cc additional people as necessary.

FYI that this is one that rolls into google3; there may be some latency in terms of knowing whether the change(s) stick.

@devoncarew
Copy link
Collaborator

The failing firefox tests - while super annoying - are known and tracked here: #292.

@devoncarew devoncarew merged commit 0efb41b into google:master Feb 22, 2025
7 of 10 checks passed
@parlough parlough deleted the fix/312 branch February 22, 2025 03:48
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 24, 2025
test (https://github.com/dart-lang/test/compare/17609bf..a833663):
  a833663e  2025-02-18  Kevin Moore  [test] ignore deprecated pkg:js (for now) (dart-lang/test#2458)

webdriver (https://github.com/google/webdriver.dart/compare/e84e9cc..b4fd859):
  b4fd859  2025-02-22  Parker Lougheed  Close HTTP clients if creating async session fails (google/webdriver.dart#318)
  bc8b61c  2025-02-22  dependabot[bot]  Bump nanasess/setup-chromedriver (google/webdriver.dart#319)
  90dc2aa  2025-02-22  Devon Carew  Update ci.yaml (google/webdriver.dart#320)
  0efb41b  2025-02-21  Parker Lougheed  Migrate async_html from `dart:html` to `package:web` (google/webdriver.dart#315)
  6085884  2025-02-21  Parker Lougheed  Update and tighten dev dependency constraints (google/webdriver.dart#317)

Change-Id: Ife06e61ae9f23f0d0715edceb9728ce3e4ba04de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411761
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to use package:web
2 participants