Skip to content

Commit b0843cf

Browse files
authored
fix(🤖): disable the optional PartitionAlloc dependency for Android
We are unable to link Skia Graphite on Android if `dawn_partition_alloc_dir` is set. We also were unable to unset it via the command line. See discussion at https://groups.google.com/g/dawn-graphics/c/3GM3ZNKzFv0
1 parent 75c756e commit b0843cf

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

build_overrides/dawn.gni

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@ dawn_wasm = false
2525
# PartitionAlloc is an optional dependency:
2626
# - MSVC compiler is not fully supported at the moment.
2727
# - Mac 11 is currently failing an assertion.
28+
# - Android doesn't link properly
2829
# TODO(351867706): Enable Mac 11.
2930
_is_msvc = is_win && !is_clang
30-
if (!_is_msvc && !is_mac) {
31+
if (!_is_msvc && !is_mac && !is_android) {
3132
dawn_partition_alloc_dir = "//third_party/externals/partition_alloc"
3233
}

0 commit comments

Comments
 (0)