Skip to content

Commit 7b64e13

Browse files
egdanielSkCQ
authored andcommitted
[graphite] Remove use of GraphiteTypesPriv and move to *Types in src.
We should only be using include/private for types that actually are needed in include/ files. I moved everything that was just in src to new src/*Types.h files. This actually left nothing in GraphiteTypesPriv for now, so I deleted it. If we actually need private types that are part of include/ we can add it back later. Bug: skia:12466 Change-Id: I180fc2032afd47bc6c5e8b9ccd4954b5d2451fc7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/471758 Reviewed-by: Chris Dalton <csmartdalton@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
1 parent c3915f7 commit 7b64e13

27 files changed

+350
-305
lines changed

experimental/graphite/include/private/GraphiteTypesPriv.h

Lines changed: 0 additions & 282 deletions
This file was deleted.

experimental/graphite/src/Buffer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#ifndef skgpu_Buffer_DEFINED
99
#define skgpu_Buffer_DEFINED
1010

11-
#include "experimental/graphite/include/private/GraphiteTypesPriv.h"
11+
#include "experimental/graphite/src/ResourceTypes.h"
1212
#include "include/core/SkRefCnt.h"
1313

1414
namespace skgpu {

experimental/graphite/src/Caps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#ifndef skgpu_Caps_DEFINED
99
#define skgpu_Caps_DEFINED
1010

11-
#include "experimental/graphite/include/private/GraphiteTypesPriv.h"
11+
#include "experimental/graphite/src/ResourceTypes.h"
1212
#include "include/core/SkImageInfo.h"
1313
#include "include/core/SkRefCnt.h"
1414

experimental/graphite/src/CommandBuffer.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
#include "experimental/graphite/src/CommandBuffer.h"
99

10-
#include "experimental/graphite/include/private/GraphiteTypesPriv.h"
1110
#include "experimental/graphite/src/GraphicsPipeline.h"
1211
#include "src/core/SkTraceEvent.h"
1312

experimental/graphite/src/CommandBuffer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#ifndef skgpu_CommandBuffer_DEFINED
99
#define skgpu_CommandBuffer_DEFINED
1010

11-
#include "experimental/graphite/include/private/GraphiteTypesPriv.h"
11+
#include "experimental/graphite/src/DrawTypes.h"
1212
#include "include/core/SkColor.h"
1313
#include "include/core/SkRect.h"
1414
#include "include/core/SkRefCnt.h"

experimental/graphite/src/ContextUtils.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include "experimental/graphite/src/ContextUtils.h"
99

1010
#include <string>
11+
#include "experimental/graphite/src/DrawTypes.h"
1112
#include "experimental/graphite/src/Uniform.h"
1213
#include "experimental/graphite/src/UniformCache.h"
1314
#include "experimental/graphite/src/UniformManager.h"

experimental/graphite/src/Device.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010

1111
#include "src/core/SkDevice.h"
1212

13-
#include "experimental/graphite/include/private/GraphiteTypesPriv.h"
1413
#include "experimental/graphite/src/DrawOrder.h"
14+
#include "experimental/graphite/src/EnumBitMask.h"
1515
#include "experimental/graphite/src/geom/Rect.h"
1616

1717
class SkStrokeRec;

experimental/graphite/src/DrawBufferManager.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ static bool can_fit(size_t requestedSize,
2929
Buffer* buffer,
3030
size_t currentOffset,
3131
size_t alignment) {
32-
size_t startOffset = AlignTo(currentOffset, alignment);
32+
size_t startOffset = SkAlignTo(currentOffset, alignment);
3333
return requestedSize <= (buffer->size() - startOffset);
3434
}
3535

@@ -117,7 +117,7 @@ std::tuple<UniformWriter, BindBufferInfo> DrawBufferManager::getUniformWriter(
117117
return {UniformWriter(), BindBufferInfo()};
118118
}
119119
}
120-
fUniformOffset = AlignTo(fUniformOffset, fUniformStartAlignment);
120+
fUniformOffset = SkAlignTo(fUniformOffset, fUniformStartAlignment);
121121
BindBufferInfo bindInfo;
122122
bindInfo.fBuffer = fCurrentUniformBuffer.get();
123123
bindInfo.fOffset = fUniformOffset;

experimental/graphite/src/DrawBufferManager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#ifndef skgpu_DrawBufferManager_DEFINED
99
#define skgpu_DrawBufferManager_DEFINED
1010

11-
#include "experimental/graphite/include/private/GraphiteTypesPriv.h"
11+
#include "experimental/graphite/src/DrawTypes.h"
1212
#include "include/core/SkRefCnt.h"
1313
#include "src/gpu/BufferWriter.h"
1414

experimental/graphite/src/DrawContext.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
#include "include/core/SkImageInfo.h"
1212
#include "include/core/SkRefCnt.h"
1313

14-
#include "experimental/graphite/include/private/GraphiteTypesPriv.h"
1514
#include "experimental/graphite/src/DrawList.h"
1615
#include "experimental/graphite/src/DrawOrder.h"
16+
#include "experimental/graphite/src/DrawTypes.h"
1717

1818
#include <vector>
1919

0 commit comments

Comments
 (0)