From 39dfe3603c0eb771577a99f59b1523c4db011a33 Mon Sep 17 00:00:00 2001 From: Ben Wagner Date: Thu, 26 Sep 2024 15:50:10 -0400 Subject: [PATCH] Suppress function UBSan on macOS "-fsanitize=function" is designed to catch when calling a function through a pointer of the wrong type (much like "-fsanitize=cfi-*call", but a completely different mechanism). However, this is currently known to have issues on macOS [0]. [0] https://github.com/llvm/llvm-project/issues/109074 Change-Id: I66f51d8190f6105f852676a8faaf694e7f0dbcca Reviewed-on: https://skia-review.googlesource.com/c/skia/+/903958 Reviewed-by: Kaylee Lubick --- gn/skia/BUILD.gn | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gn/skia/BUILD.gn b/gn/skia/BUILD.gn index 94632fa75cbd..aca9362a79bb 100644 --- a/gn/skia/BUILD.gn +++ b/gn/skia/BUILD.gn @@ -366,6 +366,10 @@ config("default") { "-fno-sanitize-recover=$sanitizers", "-fsanitize-blacklist=$_suppressions", ] + if (is_mac) { + # https://github.com/llvm/llvm-project/issues/109074 + cflags += [ "-fno-sanitize=function" ] + } if (is_win) { cflags += [