[graphite] Fix Pipeline label for when resolve-loads are relevant

While analyzing Pipeline labels from Chrome I kept seeing identical Pipeline labels that were representing different Pipelines (i.e., had different UniqueKeys).

Bug: b/394827799
Change-Id: I78fdd48290f9e20ccc73844bba9daf2fc950f65a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/961516
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

Author: rphilli

src/gpu/graphite/RenderPassDesc.cpp

@@ -132,8 +132,17 @@ SkString RenderPassDesc::toPipelineLabel() const {
     // We include the load op of the color attachment when there is a resolve attachment because
     // the load may trigger a different renderpass description.
     const char* colorLoadStr = "";
-    if (fColorAttachment.fLoadOp == LoadOp::kLoad &&
-        (fColorResolveAttachment.fTextureInfo.isValid() || fSampleCount > 1)) {
+
+    const bool loadMsaaFromResolve =
+            fColorResolveAttachment.fTextureInfo.isValid() &&
+            fColorResolveAttachment.fLoadOp == LoadOp::kLoad;
+
+    // This should, technically, check Caps::loadOpAffectsMSAAPipelines before adding the extra
+    // string. Only the Metal backend doesn't set that flag, however, so we just assume it is set
+    // to reduce plumbing. Since the Metal backend doesn't differentiate its UniqueKeys wrt
+    // resolve-loads, this can lead to instances where two Metal Pipeline labels will map to the
+    // same UniqueKey (i.e., one with "w/ msaa load" and one without it).
+    if (loadMsaaFromResolve /* && Caps::loadOpAffectsMSAAPipelines() */) {
         colorLoadStr = " w/ msaa load";
     }
 

src/gpu/graphite/dawn/DawnCaps.cpp

@@ -1016,7 +1016,7 @@ uint32_t DawnCaps::getRenderPassDescKeyForPipeline(const RenderPassDesc& renderP
     // So we need to include a bit flag to differentiate the two kinds of pipelines.
     // Also avoid returning a cached pipeline that is not compatible with the render pass using
     // ExpandResolveTexture load op and vice versa.
-    const bool shouldIncludeLoadResolveAttachmentBit = this->resolveTextureLoadOp().has_value();
+    const bool shouldIncludeLoadResolveAttachmentBit = this->loadOpAffectsMSAAPipelines();
     uint32_t loadResolveAttachmentKey = 0;
     if (shouldIncludeLoadResolveAttachmentBit &&
         renderPassDesc.fColorResolveAttachment.fTextureInfo.isValid() &&
@@ -1111,7 +1111,7 @@ bool DawnCaps::extractGraphicsDescs(const UniqueKey& key,
     LoadOp loadOp = LoadOp::kClear;
     if (renderpassDescBits & kResolveMask) {
         // This bit should only be set if Dawn supports ExpandResolveTexture load op
-        SkASSERT(this->resolveTextureLoadOp().has_value());
+        SkASSERT(this->loadOpAffectsMSAAPipelines());
         loadOp = LoadOp::kLoad;
     }
 

src/gpu/graphite/dawn/DawnGraphicsPipeline.cpp

@@ -439,7 +439,7 @@ sk_sp<DawnGraphicsPipeline> DawnGraphicsPipeline::Make(
     // Special case: a render pass loading resolve texture requires additional settings for the
     // pipeline to make it compatible.
     wgpu::ColorTargetStateExpandResolveTextureDawn pipelineMSAALoadResolveTextureDesc;
-    if (loadMsaaFromResolve && sharedContext->dawnCaps()->resolveTextureLoadOp().has_value()) {
+    if (loadMsaaFromResolve && sharedContext->dawnCaps()->loadOpAffectsMSAAPipelines()) {
         SkASSERT(device.HasFeature(wgpu::FeatureName::DawnLoadResolveTexture));
         colorTarget.nextInChain = &pipelineMSAALoadResolveTextureDesc;
         pipelineMSAALoadResolveTextureDesc.enabled = true;

src/gpu/graphite/precompile/SerializationUtils.cpp

@@ -350,7 +350,8 @@ bool DataToPipelineDesc(const Caps* caps,
 }
 
 #if defined(GPU_TEST_UTILS)
-void DumpPipelineDesc(const char* label, ShaderCodeDictionary* shaderCodeDictionary,
+void DumpPipelineDesc(const char* label,
+                      ShaderCodeDictionary* shaderCodeDictionary,
                       const GraphicsPipelineDesc& pipelineDesc,
                       const RenderPassDesc& renderPassDesc) {
     SkString pipelineStr = pipelineDesc.toString(shaderCodeDictionary);