Only eval TID and SID rules when the binary signature is valid #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlw
force-pushed
the
only-eval-tid-sid-rules-with-valid-sigs
branch
from
615bfc6 to
f672939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Team ID and Signing ID rules should only be evaluated when the binary's signature is valid. This change ensures TID/SID values are not used when looking up rules if code signature checks fail.
Additionally this updates the test
rules.dbto the latest schema and completely revamped the SantadTest to better ensure the stated purpose of each test is actually met.Related: #1120