rust_icu_sys: fix build with clang-19 #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building in a Fedora 41 container againts clang-19 results in a lib.rs (output from bindgen) that is missing key functions like u_strFromUTF8. Digging deeper, this is a problem with bindgen, see <rust-lang/rust-bindgen#2945>. Update bindgen to a newer version which is just new enough to fix the problem. Fixes <google#305>.
Contributor
Author
|
Thanks for the review. :-) |
Contributor
Author
|
@filmil do you think you could cut a new release in the near future? If I see correctly, the last release was in February, and the last release doesn't build on stable Fedora till this PR hits a release. Thanks. :-) |
Member
|
I recommend against using release tags for pinning the source. Please use
commit IDs as those are immutable.
…On Mon, Dec 2, 2024 at 10:46 AM Miklos Vajna ***@***.***> wrote:
@filmil <https://github.com/filmil> do you think you could cut a new
release in the near future? If I see correctly, the last release was in
February, and the last release doesn't build on stable Fedora till this PR
hits a release. Thanks. :-)
—
Reply to this email directly, view it on GitHub
<#306 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB4GMHA2FGFQTMR3VLPHBL2DSTGVAVCNFSM6AAAAABRPMCD5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJSGQYTIMBTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
I didn't mean git tags, I meant a release to crates.io. Or do you discourage the usage of those releases, too? :-) Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building in a Fedora 41 container againts clang-19 results in a lib.rs (output from bindgen) that is missing key functions like u_strFromUTF8.
Digging deeper, this is a problem with bindgen, see rust-lang/rust-bindgen#2945.
Update bindgen to a newer version which is just new enough to fix the problem.
Fixes #305.