From b5d3bf580fb82bb2f1798388064d3690f5a9b60a Mon Sep 17 00:00:00 2001
From: "Ralf W. Grosse-Kunstleve" <rwgk@google.com>
Date: Mon, 12 Feb 2024 02:20:11 -0800
Subject: [PATCH] clang-tidy auto-fixes

---
 include/pybind11/pybind11.h | 16 ++++++++++------
 tests/pybind11_tests.h      |  2 +-
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/include/pybind11/pybind11.h b/include/pybind11/pybind11.h
index eb078bdb..eecf52bb 100644
--- a/include/pybind11/pybind11.h
+++ b/include/pybind11/pybind11.h
@@ -712,7 +712,7 @@ class cpp_function : public function {
                 // chain.
                 chain_start = rec;
                 rec->next = chain;
-                auto py_func_rec
+                auto *py_func_rec
                     = (detail::function_record_PyObject *) PyCFunction_GET_SELF(m_ptr);
                 py_func_rec->cpp_func_rec = unique_rec.release();
                 guarded_strdup.release();
@@ -1321,34 +1321,38 @@ namespace function_record_PyTypeObject_methods {
 
 inline PyObject *tp_new_impl(PyTypeObject *type, PyObject *args, PyObject *kwds) {
     // Create a new instance using the type's tp_alloc slot.
-    if (type)
+    if (type) {
         pybind11_fail("INTENTIONAL BREAKAGE: tp_new_impl");
+    }
     return PyType_GenericNew(type, args, kwds);
 }
 
 inline PyObject *tp_alloc_impl(PyTypeObject *type, Py_ssize_t nitems) {
     // Use Python's default memory allocation mechanism to allocate a new instance
     // and initialize all its contents to NULL.
-    if (type)
+    if (type) {
         pybind11_fail("INTENTIONAL BREAKAGE: tp_alloc_impl");
+    }
     return PyType_GenericAlloc(type, nitems);
 }
 
 inline int tp_init_impl(PyObject *self, PyObject *, PyObject *) {
-    if (self)
+    if (self) {
         pybind11_fail("INTENTIONAL BREAKAGE: tp_init_impl");
+    }
     return -1;
 }
 
 inline void tp_dealloc_impl(PyObject *self) {
-    auto py_func_rec = (function_record_PyObject *) self;
+    auto *py_func_rec = (function_record_PyObject *) self;
     cpp_function::destruct(py_func_rec->cpp_func_rec);
     py_func_rec->cpp_func_rec = nullptr;
 }
 
 inline void tp_free_impl(void *self) {
-    if (self)
+    if (self) {
         pybind11_fail("INTENTIONAL BREAKAGE: tp_free_impl");
+    }
 }
 
 } // namespace function_record_PyTypeObject_methods
diff --git a/tests/pybind11_tests.h b/tests/pybind11_tests.h
index 3924cf05..7be58feb 100644
--- a/tests/pybind11_tests.h
+++ b/tests/pybind11_tests.h
@@ -59,7 +59,7 @@ class UnusualOpRef {
     using NonTrivialType = std::shared_ptr<int>; // Almost any non-trivial type will do.
     // Overriding operator& should not break pybind11.
     NonTrivialType operator&() { return non_trivial_member; }
-    const NonTrivialType operator&() const { return non_trivial_member; }
+    NonTrivialType operator&() const { return non_trivial_member; }
 
 private:
     NonTrivialType non_trivial_member;