Skip to content

Conversation

@osa1
Copy link
Member

@osa1 osa1 commented Sep 29, 2025

@sigurdm @devoncarew do you have anything else to add to this release?

Note: pubspec versions are already have the right versions (no -wip suffix).

@osa1 osa1 requested review from devoncarew and sigurdm September 29, 2025 10:59
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:protobuf 5.0.0 ready to publish protobuf-v5.0.0
package:protoc_plugin 23.0.0 ready to publish protoc_plugin-v23.0.0

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Collaborator

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good

@osa1
Copy link
Member Author

osa1 commented Sep 29, 2025

We could release fixnum and bump fixnum dependency here, to get the perf benefits with the new fixnum.

I restarted the g3 job to roll fixnum to g3 in https://dart-review.googlesource.com/c/sdk/+/449020 to see if the issues with conditional imports was fixed.

@sigurdm
Copy link
Collaborator

sigurdm commented Sep 29, 2025

Would the new fixnum not be compatible? Such that we really don't need to change the constraint?

Copy link
Contributor

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have anything else to add to this release?

Nope - lgtm!

@osa1 osa1 merged commit fb89979 into master Sep 29, 2025
12 checks passed
@osa1 osa1 deleted the new_release branch September 29, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants