Skip to content

Fix unknown JSON handling #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 29, 2025
Merged

Fix unknown JSON handling #1058

merged 4 commits into from
Sep 29, 2025

Conversation

@osa1
Copy link
Member

@osa1 osa1 commented Sep 29, 2025

  • Fix hash code and equality handling with unknown JSON data. (cl/613592094)
  • Fix converting unknown JSON data to Dart when deserializing, and to JS when serializing. (cl/812691555)
  • Make unknown JSON data type Object? instead of dynamic to prevent accidentally making dynamic calls. (cl/812691555)
  • Also fix a sync error in b761358 where the _unknownJsonData = null line was added to _ensureUnknownFields instead of _clear.

@osa1 osa1 requested a review from sigurdm September 29, 2025 10:32
@osa1 osa1 marked this pull request as ready for review September 29, 2025 10:32
@osa1 osa1 merged commit ccf56f3 into google:master Sep 29, 2025
11 of 12 checks passed
@osa1 osa1 deleted the unknown_json_data_fixes branch September 29, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@osa1 @sigurdm