Don't generate createRepeated members (#1074)

`createRepeated` members are not that useful, because `PbList` doesn't provide
much over the standard library `List`, and `MyMessage.createRepeated()` can be
replaced with `<MyMessage>[]`.

To reduce generated code sizes and dependencies to `PbList`, remove the
`createRepeated` members.

Author: osa1

protoc_plugin/CHANGELOG.md

@@ -1,3 +1,12 @@
+## 24.0.0
+
+* **Breaking:** Don't generate `createRepeated` methods.
+
+  These methods are not too useful as there isn't much you can do with a
+  `PbList` that you can't do with a `List`.
+
+  To migrate, replace `MyMessage.createRepeated()` with `<MyMessage>[]`.
+
 ## 23.0.0
 
 Note: this version requires protobuf 5.0.0.

protoc_plugin/lib/names.dart

@@ -661,7 +661,6 @@ const List<String> _dartReservedWords = [
 // the base GeneratedMessage class determined by reflection.
 const _generatedMessageNames = <String>[
   'create',
-  'createRepeated',
   'getDefault',
   'List',
   'notSet',

protoc_plugin/lib/src/gen/dart_options.pb.dart

@@ -62,7 +62,6 @@ class DartMixin extends $pb.GeneratedMessage {
   static DartMixin create() => DartMixin._();
   @$core.override
   DartMixin createEmptyInstance() => create();
-  static $pb.PbList<DartMixin> createRepeated() => $pb.PbList<DartMixin>();
   @$core.pragma('dart2js:noInline')
   static DartMixin getDefault() =>
       _defaultInstance ??= $pb.GeneratedMessage.$_defaultFor<DartMixin>(create);
@@ -142,7 +141,6 @@ class Imports extends $pb.GeneratedMessage {
   static Imports create() => Imports._();
   @$core.override
   Imports createEmptyInstance() => create();
-  static $pb.PbList<Imports> createRepeated() => $pb.PbList<Imports>();
   @$core.pragma('dart2js:noInline')
   static Imports getDefault() =>
       _defaultInstance ??= $pb.GeneratedMessage.$_defaultFor<Imports>(create);

protoc_plugin/lib/src/gen/google/api/client.pb.dart

@@ -78,8 +78,6 @@ class CommonLanguageSettings extends $pb.GeneratedMessage {
   static CommonLanguageSettings create() => CommonLanguageSettings._();
   @$core.override
   CommonLanguageSettings createEmptyInstance() => create();
-  static $pb.PbList<CommonLanguageSettings> createRepeated() =>
-      $pb.PbList<CommonLanguageSettings>();
   @$core.pragma('dart2js:noInline')
   static CommonLanguageSettings getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<CommonLanguageSettings>(create);
@@ -198,8 +196,6 @@ class ClientLibrarySettings extends $pb.GeneratedMessage {
   static ClientLibrarySettings create() => ClientLibrarySettings._();
   @$core.override
   ClientLibrarySettings createEmptyInstance() => create();
-  static $pb.PbList<ClientLibrarySettings> createRepeated() =>
-      $pb.PbList<ClientLibrarySettings>();
   @$core.pragma('dart2js:noInline')
   static ClientLibrarySettings getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<ClientLibrarySettings>(create);
@@ -412,7 +408,6 @@ class Publishing extends $pb.GeneratedMessage {
   static Publishing create() => Publishing._();
   @$core.override
   Publishing createEmptyInstance() => create();
-  static $pb.PbList<Publishing> createRepeated() => $pb.PbList<Publishing>();
   @$core.pragma('dart2js:noInline')
   static Publishing getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<Publishing>(create);
@@ -578,8 +573,6 @@ class JavaSettings extends $pb.GeneratedMessage {
   static JavaSettings create() => JavaSettings._();
   @$core.override
   JavaSettings createEmptyInstance() => create();
-  static $pb.PbList<JavaSettings> createRepeated() =>
-      $pb.PbList<JavaSettings>();
   @$core.pragma('dart2js:noInline')
   static JavaSettings getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<JavaSettings>(create);
@@ -676,7 +669,6 @@ class CppSettings extends $pb.GeneratedMessage {
   static CppSettings create() => CppSettings._();
   @$core.override
   CppSettings createEmptyInstance() => create();
-  static $pb.PbList<CppSettings> createRepeated() => $pb.PbList<CppSettings>();
   @$core.pragma('dart2js:noInline')
   static CppSettings getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<CppSettings>(create);
@@ -736,7 +728,6 @@ class PhpSettings extends $pb.GeneratedMessage {
   static PhpSettings create() => PhpSettings._();
   @$core.override
   PhpSettings createEmptyInstance() => create();
-  static $pb.PbList<PhpSettings> createRepeated() => $pb.PbList<PhpSettings>();
   @$core.pragma('dart2js:noInline')
   static PhpSettings getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<PhpSettings>(create);
@@ -810,8 +801,6 @@ class PythonSettings_ExperimentalFeatures extends $pb.GeneratedMessage {
       PythonSettings_ExperimentalFeatures._();
   @$core.override
   PythonSettings_ExperimentalFeatures createEmptyInstance() => create();
-  static $pb.PbList<PythonSettings_ExperimentalFeatures> createRepeated() =>
-      $pb.PbList<PythonSettings_ExperimentalFeatures>();
   @$core.pragma('dart2js:noInline')
   static PythonSettings_ExperimentalFeatures getDefault() =>
       _defaultInstance ??= $pb.GeneratedMessage.$_defaultFor<
@@ -905,8 +894,6 @@ class PythonSettings extends $pb.GeneratedMessage {
   static PythonSettings create() => PythonSettings._();
   @$core.override
   PythonSettings createEmptyInstance() => create();
-  static $pb.PbList<PythonSettings> createRepeated() =>
-      $pb.PbList<PythonSettings>();
   @$core.pragma('dart2js:noInline')
   static PythonSettings getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<PythonSettings>(create);
@@ -980,8 +967,6 @@ class NodeSettings extends $pb.GeneratedMessage {
   static NodeSettings create() => NodeSettings._();
   @$core.override
   NodeSettings createEmptyInstance() => create();
-  static $pb.PbList<NodeSettings> createRepeated() =>
-      $pb.PbList<NodeSettings>();
   @$core.pragma('dart2js:noInline')
   static NodeSettings getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<NodeSettings>(create);
@@ -1071,8 +1056,6 @@ class DotnetSettings extends $pb.GeneratedMessage {
   static DotnetSettings create() => DotnetSettings._();
   @$core.override
   DotnetSettings createEmptyInstance() => create();
-  static $pb.PbList<DotnetSettings> createRepeated() =>
-      $pb.PbList<DotnetSettings>();
   @$core.pragma('dart2js:noInline')
   static DotnetSettings getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<DotnetSettings>(create);
@@ -1167,8 +1150,6 @@ class RubySettings extends $pb.GeneratedMessage {
   static RubySettings create() => RubySettings._();
   @$core.override
   RubySettings createEmptyInstance() => create();
-  static $pb.PbList<RubySettings> createRepeated() =>
-      $pb.PbList<RubySettings>();
   @$core.pragma('dart2js:noInline')
   static RubySettings getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<RubySettings>(create);
@@ -1235,7 +1216,6 @@ class GoSettings extends $pb.GeneratedMessage {
   static GoSettings create() => GoSettings._();
   @$core.override
   GoSettings createEmptyInstance() => create();
-  static $pb.PbList<GoSettings> createRepeated() => $pb.PbList<GoSettings>();
   @$core.pragma('dart2js:noInline')
   static GoSettings getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<GoSettings>(create);
@@ -1325,8 +1305,6 @@ class MethodSettings_LongRunning extends $pb.GeneratedMessage {
   static MethodSettings_LongRunning create() => MethodSettings_LongRunning._();
   @$core.override
   MethodSettings_LongRunning createEmptyInstance() => create();
-  static $pb.PbList<MethodSettings_LongRunning> createRepeated() =>
-      $pb.PbList<MethodSettings_LongRunning>();
   @$core.pragma('dart2js:noInline')
   static MethodSettings_LongRunning getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<MethodSettings_LongRunning>(create);
@@ -1432,8 +1410,6 @@ class MethodSettings extends $pb.GeneratedMessage {
   static MethodSettings create() => MethodSettings._();
   @$core.override
   MethodSettings createEmptyInstance() => create();
-  static $pb.PbList<MethodSettings> createRepeated() =>
-      $pb.PbList<MethodSettings>();
   @$core.pragma('dart2js:noInline')
   static MethodSettings getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<MethodSettings>(create);
@@ -1543,8 +1519,6 @@ class SelectiveGapicGeneration extends $pb.GeneratedMessage {
   static SelectiveGapicGeneration create() => SelectiveGapicGeneration._();
   @$core.override
   SelectiveGapicGeneration createEmptyInstance() => create();
-  static $pb.PbList<SelectiveGapicGeneration> createRepeated() =>
-      $pb.PbList<SelectiveGapicGeneration>();
   @$core.pragma('dart2js:noInline')
   static SelectiveGapicGeneration getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<SelectiveGapicGeneration>(create);

protoc_plugin/lib/src/gen/google/api/http.pb.dart

@@ -62,7 +62,6 @@ class Http extends $pb.GeneratedMessage {
   static Http create() => Http._();
   @$core.override
   Http createEmptyInstance() => create();
-  static $pb.PbList<Http> createRepeated() => $pb.PbList<Http>();
   @$core.pragma('dart2js:noInline')
   static Http getDefault() =>
       _defaultInstance ??= $pb.GeneratedMessage.$_defaultFor<Http>(create);
@@ -434,7 +433,6 @@ class HttpRule extends $pb.GeneratedMessage {
   static HttpRule create() => HttpRule._();
   @$core.override
   HttpRule createEmptyInstance() => create();
-  static $pb.PbList<HttpRule> createRepeated() => $pb.PbList<HttpRule>();
   @$core.pragma('dart2js:noInline')
   static HttpRule getDefault() =>
       _defaultInstance ??= $pb.GeneratedMessage.$_defaultFor<HttpRule>(create);
@@ -614,8 +612,6 @@ class CustomHttpPattern extends $pb.GeneratedMessage {
   static CustomHttpPattern create() => CustomHttpPattern._();
   @$core.override
   CustomHttpPattern createEmptyInstance() => create();
-  static $pb.PbList<CustomHttpPattern> createRepeated() =>
-      $pb.PbList<CustomHttpPattern>();
   @$core.pragma('dart2js:noInline')
   static CustomHttpPattern getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<CustomHttpPattern>(create);

protoc_plugin/lib/src/gen/google/api/routing.pb.dart

@@ -416,7 +416,6 @@ class RoutingRule extends $pb.GeneratedMessage {
   static RoutingRule create() => RoutingRule._();
   @$core.override
   RoutingRule createEmptyInstance() => create();
-  static $pb.PbList<RoutingRule> createRepeated() => $pb.PbList<RoutingRule>();
   @$core.pragma('dart2js:noInline')
   static RoutingRule getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<RoutingRule>(create);
@@ -475,8 +474,6 @@ class RoutingParameter extends $pb.GeneratedMessage {
   static RoutingParameter create() => RoutingParameter._();
   @$core.override
   RoutingParameter createEmptyInstance() => create();
-  static $pb.PbList<RoutingParameter> createRepeated() =>
-      $pb.PbList<RoutingParameter>();
   @$core.pragma('dart2js:noInline')
   static RoutingParameter getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<RoutingParameter>(create);

protoc_plugin/lib/src/gen/google/protobuf/compiler/plugin.pb.dart

@@ -70,7 +70,6 @@ class Version extends $pb.GeneratedMessage {
   static Version create() => Version._();
   @$core.override
   Version createEmptyInstance() => create();
-  static $pb.PbList<Version> createRepeated() => $pb.PbList<Version>();
   @$core.pragma('dart2js:noInline')
   static Version getDefault() =>
       _defaultInstance ??= $pb.GeneratedMessage.$_defaultFor<Version>(create);
@@ -172,8 +171,6 @@ class CodeGeneratorRequest extends $pb.GeneratedMessage {
   static CodeGeneratorRequest create() => CodeGeneratorRequest._();
   @$core.override
   CodeGeneratorRequest createEmptyInstance() => create();
-  static $pb.PbList<CodeGeneratorRequest> createRepeated() =>
-      $pb.PbList<CodeGeneratorRequest>();
   @$core.pragma('dart2js:noInline')
   static CodeGeneratorRequest getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<CodeGeneratorRequest>(create);
@@ -289,8 +286,6 @@ class CodeGeneratorResponse_File extends $pb.GeneratedMessage {
   static CodeGeneratorResponse_File create() => CodeGeneratorResponse_File._();
   @$core.override
   CodeGeneratorResponse_File createEmptyInstance() => create();
-  static $pb.PbList<CodeGeneratorResponse_File> createRepeated() =>
-      $pb.PbList<CodeGeneratorResponse_File>();
   @$core.pragma('dart2js:noInline')
   static CodeGeneratorResponse_File getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<CodeGeneratorResponse_File>(create);
@@ -444,8 +439,6 @@ class CodeGeneratorResponse extends $pb.GeneratedMessage {
   static CodeGeneratorResponse create() => CodeGeneratorResponse._();
   @$core.override
   CodeGeneratorResponse createEmptyInstance() => create();
-  static $pb.PbList<CodeGeneratorResponse> createRepeated() =>
-      $pb.PbList<CodeGeneratorResponse>();
   @$core.pragma('dart2js:noInline')
   static CodeGeneratorResponse getDefault() => _defaultInstance ??=
       $pb.GeneratedMessage.$_defaultFor<CodeGeneratorResponse>(create);