Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typo #574

Merged
merged 1 commit into from
Oct 23, 2020
Merged

chore: fix typo #574

merged 1 commit into from
Oct 23, 2020

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Oct 22, 2020

arugments -> arguments

@google-cla google-cla bot added the cla: yes label Oct 22, 2020
@codecov-io
Copy link

codecov-io commented Oct 22, 2020 •
edited
Loading

Codecov Report

Merging #574 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files          78       78           
  Lines       14074    14074           
=======================================
  Hits         9451     9451           
  Misses       3788     3788           
  Partials      835      835
Impacted Files Coverage Δ
internal/graph/graph.go 28.03% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef5528...cac26f5. Read the comment docs.

@aalexand aalexand merged commit 163956e into google:master Oct 23, 2020
NHDaly added a commit to NHDaly/Yggdrasil that referenced this pull request Nov 13, 2020
@NHDaly
Update pprof to latest revision
692e645 
Bump from 20191205061153 => 20201109224723

My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`)

Includes:
- google/pprof#564
- google/pprof#575
- google/pprof#574
- google/pprof#571
- google/pprof#572
- google/pprof#570
- google/pprof#562
- google/pprof#561
- google/pprof#565
- google/pprof#560
- google/pprof#563
- google/pprof#557
- google/pprof#554
- google/pprof#552
- google/pprof#545
- google/pprof#549
- google/pprof#547
- google/pprof#541
- google/pprof#534
- google/pprof#542
- google/pprof#535
- google/pprof#531
- google/pprof#530
- google/pprof#528
- google/pprof#522
- google/pprof#525
- google/pprof#527
- google/pprof#519
- google/pprof#520
- google/pprof#517
- google/pprof#518
- google/pprof#514
- google/pprof#513
- google/pprof#510
- google/pprof#508
- google/pprof#506
- google/pprof#509
- google/pprof#504
@NHDaly NHDaly mentioned this pull request Nov 13, 2020
Merged
giordano added a commit to JuliaPackaging/Yggdrasil that referenced this pull request Nov 13, 2020
@NHDaly @giordano
Update pprof to latest revision (#2096)
0784405 
* Update pprof to latest revision

Bump from 20191205061153 => 20201109224723

My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`)

Includes:
- google/pprof#564
- google/pprof#575
- google/pprof#574
- google/pprof#571
- google/pprof#572
- google/pprof#570
- google/pprof#562
- google/pprof#561
- google/pprof#565
- google/pprof#560
- google/pprof#563
- google/pprof#557
- google/pprof#554
- google/pprof#552
- google/pprof#545
- google/pprof#549
- google/pprof#547
- google/pprof#541
- google/pprof#534
- google/pprof#542
- google/pprof#535
- google/pprof#531
- google/pprof#530
- google/pprof#528
- google/pprof#522
- google/pprof#525
- google/pprof#527
- google/pprof#519
- google/pprof#520
- google/pprof#517
- google/pprof#518
- google/pprof#514
- google/pprof#513
- google/pprof#510
- google/pprof#508
- google/pprof#506
- google/pprof#509
- google/pprof#504

* Update P/pprof/build_tarballs.jl - use a real version number

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

* Remove now unused `timestamp`

* [pprof] Use `GitSource`

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
gmarin13 pushed a commit to gmarin13/pprof that referenced this pull request Dec 17, 2020
@orisano
chore: fix typo (google#574)
1e52387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalyanac kalyanac kalyanac approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orisano @codecov-io @kalyanac @aalexand