Skip to content

Update Github Action badge to reference the CI status page. #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2020
Merged

Update Github Action badge to reference the CI status page. #549

merged 2 commits into from
Jun 30, 2020

Conversation

wyk9787
Copy link
Contributor

@wyk9787 wyk9787 commented Jun 30, 2020

No description provided.

@wyk9787 wyk9787 requested a review from aalexand June 30, 2020 01:48
@wyk9787 wyk9787 mentioned this pull request Jun 30, 2020
Merged
aalexand
aalexand reviewed Jun 30, 2020
View reviewed changes
README.md Outdated
@@ -1,4 +1,4 @@
![](https://github.com/google/pprof/workflows/ci/badge.svg)
[![](https://github.com/google/pprof/workflows/ci/badge.svg)](https://github.com/google/pprof/actions)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you use empty description, unlike the other two links below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following https://help.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow#adding-a-workflow-status-badge-to-your-repository.

I originally thought this text will change the text being rendered. But actually it doesn't really matter here.
Now I changed those three names to be more consistent.

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2020 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.39%. Comparing base (f08ab7d) to head (8a99f76).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
- Coverage   68.41%   68.39%   -0.02%     
==========================================
  Files          78       78              
  Lines       16088    16088              
==========================================
- Hits        11006    11004       -2     
- Misses       4226     4227       +1     
- Partials      856      857       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aalexand aalexand merged commit 6609db7 into master Jun 30, 2020
NHDaly added a commit to NHDaly/Yggdrasil that referenced this pull request Nov 13, 2020
@NHDaly
Update pprof to latest revision
692e645 
Bump from 20191205061153 => 20201109224723

My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`)

Includes:
- google/pprof#564
- google/pprof#575
- google/pprof#574
- google/pprof#571
- google/pprof#572
- google/pprof#570
- google/pprof#562
- google/pprof#561
- google/pprof#565
- google/pprof#560
- google/pprof#563
- google/pprof#557
- google/pprof#554
- google/pprof#552
- google/pprof#545
- google/pprof#549
- google/pprof#547
- google/pprof#541
- google/pprof#534
- google/pprof#542
- google/pprof#535
- google/pprof#531
- google/pprof#530
- google/pprof#528
- google/pprof#522
- google/pprof#525
- google/pprof#527
- google/pprof#519
- google/pprof#520
- google/pprof#517
- google/pprof#518
- google/pprof#514
- google/pprof#513
- google/pprof#510
- google/pprof#508
- google/pprof#506
- google/pprof#509
- google/pprof#504
@NHDaly NHDaly mentioned this pull request Nov 13, 2020
Merged
giordano added a commit to JuliaPackaging/Yggdrasil that referenced this pull request Nov 13, 2020
@NHDaly @giordano
Update pprof to latest revision (#2096)
0784405 
* Update pprof to latest revision

Bump from 20191205061153 => 20201109224723

My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`)

Includes:
- google/pprof#564
- google/pprof#575
- google/pprof#574
- google/pprof#571
- google/pprof#572
- google/pprof#570
- google/pprof#562
- google/pprof#561
- google/pprof#565
- google/pprof#560
- google/pprof#563
- google/pprof#557
- google/pprof#554
- google/pprof#552
- google/pprof#545
- google/pprof#549
- google/pprof#547
- google/pprof#541
- google/pprof#534
- google/pprof#542
- google/pprof#535
- google/pprof#531
- google/pprof#530
- google/pprof#528
- google/pprof#522
- google/pprof#525
- google/pprof#527
- google/pprof#519
- google/pprof#520
- google/pprof#517
- google/pprof#518
- google/pprof#514
- google/pprof#513
- google/pprof#510
- google/pprof#508
- google/pprof#506
- google/pprof#509
- google/pprof#504

* Update P/pprof/build_tarballs.jl - use a real version number

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

* Remove now unused `timestamp`

* [pprof] Use `GitSource`

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
gmarin13 pushed a commit to gmarin13/pprof that referenced this pull request Dec 17, 2020
@wyk9787
Update Github Action badge to reference the CI status page. (google#549)
9160565 
* Update Github Action badge.

* Update badge name.
@nolanmar511 nolanmar511 deleted the github_action_badge branch January 28, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalexand aalexand aalexand approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wyk9787 @codecov-commenter @aalexand @googlebot