Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maven dependency management to override client #1140

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Jul 25, 2024

Currently, Maven dependency management is not added to the override client so they are not considered when computing Maven dependency graph.

This PR adds all direct dependency management to override client so that transitive dependencies are resolved correctly.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.27%. Comparing base (2e60dcc) to head (b3846b1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1140      +/-   ##
==========================================
+ Coverage   65.21%   65.27%   +0.05%     
==========================================
  Files         162      162              
  Lines       13424    13437      +13     
==========================================
+ Hits         8755     8771      +16     
+ Misses       4185     4183       -2     
+ Partials      484      483       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuixq cuixq marked this pull request as ready for review July 25, 2024 06:49
Copy link
Member

@michaelkedar michaelkedar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cuixq cuixq merged commit bc0e8da into google:main Jul 25, 2024
13 checks passed
@cuixq cuixq deleted the transitive branch July 25, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants