Fixed installing extra test images #9681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidKorczynski
approved these changes
Feb 11, 2023
eamonnmcmanus
pushed a commit
to eamonnmcmanus/oss-fuzz
that referenced
this pull request
Mar 15, 2023
Over at python-pillow, our CIFuzz job has [started failing](https://github.com/python-pillow/Pillow/actions/runs/4147683686/jobs/7174854267#step:4:7800) - > depends/install_extra_test_images.sh: line 6: ./download-and-extract.sh: No such file or directory This is because we recently merged python-pillow/Pillow#6918, which changes `depends/install_extra_test_images.sh` to call `./download-and-extract.sh`, which exists inside [`depends`](https://github.com/python-pillow/Pillow/tree/main/depends). So when https://github.com/google/oss-fuzz/blob/00b08f6592b90d438e113138c64cd4025fbb3bdf/projects/pillow/Dockerfile#L41 runs, it can't find `./download-and-extract.sh`, because it is running from the base Pillow directory. So this PR changes the command to run from inside `depends` instead. Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over at python-pillow, our CIFuzz job has started failing -
This is because we recently merged python-pillow/Pillow#6918, which changes
depends/install_extra_test_images.shto call./download-and-extract.sh, which exists insidedepends. So whenoss-fuzz/projects/pillow/Dockerfile
Line 41 in 00b08f6
runs, it can't find
./download-and-extract.sh, because it is running from the base Pillow directory.So this PR changes the command to run from inside
dependsinstead.