Coerce positive error from open() to negative code #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAudio could sometimes return a positive number (1) as an error code. That was confusing to apps like OboeTester, which often for (result < 0). The fix is to coerce these bogus error codes to ErrorInternal. Bump Oboe to 1.7.2 and OboeTester to 2.3.7.
robertwu1
reviewed
Feb 21, 2023
robertwu1
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AAudio could sometimes return a positive number (1) as an error code. That was confusing to apps like OboeTester, which often look for (result < 0).
The fix is to coerce these bogus error codes to ErrorInternal.
Bump Oboe to 1.7.2 and OboeTester to 2.3.7.