Improved OAuth2l Client Interface #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Uses advanced go-flags library to parse command-line flags, which improves organization, flexibility, and better built-in help doc. -Added explicit flags for GUAC arguments such as scope and audience. -Added support for a new "curl" command. -Fixed variadic bug in sso.go that incorrectly handles multiple scopes.
Also removed short (single character) flags to improve clarity and avoid misuse.
-"url" is now an explicit required flag for "curl" command. -introduced command-specific options for "fetch", "header", and "curl" to improve context-aware help messages and enforce required parameters. -Updated documentation.
shinfan
reviewed
Jul 12, 2019
-Added helper methods to main.go -Added support for space-delimited scope -Updated README.md
shinfan
requested changes
Aug 3, 2019
README.md
Outdated
| @@ -7,7 +7,24 @@ working with | |||
| written in Go. Its primary use is to fetch and print OAuth 2.0 access | |||
| tokens, which can be used with other command-line tools and shell scripts. | |||
|
|
|||
| ## Previous Version | |||
| ## July 2019 Update | |||
There was a problem hiding this comment.
Let's not add this here, we can create a new release after this one and add this to the release log.
There was a problem hiding this comment.
Ok. Let's create a proper tagged release after this change. Reverting this part of the read me for now.
| ) | ||
|
|
||
| // Executes curl command with provided header and params. | ||
| func CurlCommand(cli string, header string, url string, extraArgs ...string) { |
There was a problem hiding this comment.
Can we change this to just take the token so we don't have to use BuildHeader every time before invoking this?
There was a problem hiding this comment.
I think it's better to have "header" as the parameter here for several reasons:
- The logic to construct the authorization header from "token type" and "access token" has nothing to with the curl command itself, which is generic. The curl util is more flexible in its current form.
- The SSO path does not give us a "token object" to work with, and uses BuildHeader differently. It is cleaner to pass the final "header" into the CurlCommand function.
-Will put updates into release notes for official release. -Minor formatting changes
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Enhanced command-line flag parsing via "go-flags" library. This improves code readability and provides context-aware help messages. Also provides enforcement of required flags, and rejects incompatible flags.
-Added explicit flags for GUAC arguments such as "scope" and "audience". Maintains backward compatibility with implicit flags and deprecated flags.
-Added support for a new "curl" command, which is a short-cut for making a curl request with a fetched token.
-Updated documentation.