-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add digit separators #1160
base: master
Are you sure you want to change the base?
Add digit separators #1160
Conversation
I'm in favor of this. We need to also:
See https://github.com/google/jsonnet?tab=readme-ov-file#locally-serving-the-website for working on documentation.
|
Thanks @sbarzowski, I'll get cracking on those. |
@sbarzowski I think I'm ready for another round of feedback on this one. I suspect these might need a little more help:
|
Anything I can do to push this forward @sbarzowski? Thanks! |
This PR adds digit separators (
1_000
) to Jsonnet's numeric constants.Accompanying issue with format proposal: #1155