Skip to content

Pass field metadata to type helpers. #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Pass field metadata to type helpers. #70

wants to merge 19 commits into from

Conversation

sasha-caleo
Copy link
Contributor

We're struggling from the lack of control over serialization of fields. We need a way to get field annotations in custom type helpers to improve logic of serialization.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@sasha-caleo sasha-caleo reopened this Nov 13, 2017
@googlebot
Copy link

CLAs look good, thanks!

@sasha-caleo sasha-caleo deleted the pass-field-metadata-to-type-helpers branch November 13, 2017 16:23
@kevmoo
Copy link
Collaborator

kevmoo commented Nov 23, 2017

@caleo-git want to try again? Just landed the required PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants