Skip to content

WIP: remove toJson helper – not sure I like this... #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: remove toJson helper – not sure I like this... #36

wants to merge 1 commit into from

Conversation

kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Aug 21, 2017

I think the runtime cost of the inline method must be pretty small – likely inlined in dart2js.

@kevmoo kevmoo requested a review from natebosch August 21, 2017 19:25
natebosch
natebosch approved these changes Aug 21, 2017
View reviewed changes
Copy link
Member

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I do find this a little easier to follow - but I don't have strong opinions on it.

@kevmoo
Copy link
Collaborator Author

kevmoo commented Aug 21, 2017

Eh...I'm not moved enough to want to land it...

@kevmoo kevmoo closed this Aug 21, 2017
@kevmoo kevmoo deleted the remove_helper_method branch August 21, 2017 19:37
@Gopinathp Gopinathp mentioned this pull request Jan 14, 2020
Closed
@FabioPagano FabioPagano mentioned this pull request Nov 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @natebosch