Improve toJson generation with some no-write null fields #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
requested changes
Aug 21, 2017
CHANGELOG.md
Outdated
| @@ -1,3 +1,8 @@ | |||
| ## 0.2.3 | |||
|
|
|||
| * Write out `toJson` methods more efficiently the first fields written are not | |||
There was a problem hiding this comment.
is this missing a word or some punctuation?
| $map['orders'] = orders; | ||
| return $map; | ||
| writeNotNull('middleName', middleName); | ||
| val['lastName'] = lastName; |
There was a problem hiding this comment.
can/should we get these other non-null fields into the initial map?
There was a problem hiding this comment.
Sadly, no. We want to keep the fields in consistent order.
| 'firstName': firstName, | ||
| }; | ||
|
|
||
| void writeNotNull(String key, dynamic value) { |
There was a problem hiding this comment.
taking a look at this - I might skip the extra method and inline the conditionals through the rest. It's noisy but shouldn't matter since it's generated code
There was a problem hiding this comment.
Hrm. Maybe. Will look at in another.
natebosch
approved these changes
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.