WIP: Trying to support the latest version of pkg/build #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's entirely possible the new build_runner slowed things down though I wouldn't expect by much - is it deadlocking altogether? If so it's probably a build_runner bug |
|
Ah Looks most likely to be a build_runner bug. Will dig |
|
I just pushed a patch to that PR that sets the exit code
…On Tue, Aug 15, 2017 at 10:48 AM, Nate Bosch ***@***.***> wrote:
Ah pub run test just doesn't show us the stderr output - we should fix
that :)
Looks most likely to be a build_runner bug. Will dig
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCir5LJ3_5yczyn_gnHr6wx-lOGGLvks5sYb25gaJpZM4O3udY>
.
|
|
Definitely a bug in build_runner. |
|
Ok, pub upgrade and this should work now. |
natebosch
approved these changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See failures – your bug or mine?