Fix Dart formatting in JSON strings, standardized strings, etc #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preparing to enable lint: prefer_single_quotes
natebosch
reviewed
Aug 1, 2017
lib/src/json_literal_generator.dart
Outdated
|
|
||
| return '$marked _\$${element.displayName}JsonLiteral = $thing;'; | ||
| } | ||
| } | ||
|
|
||
| bool _isConstType(value) { | ||
| return value == null || value is String || value is num || value is bool; | ||
| String _jsonLiteralAsDart(dynamic value, bool asConst) { |
There was a problem hiding this comment.
maybe break out some methods?
This is really hard to follow. Also a Doc comment would be nice
natebosch
approved these changes
Aug 2, 2017
lib/src/json_literal_generator.dart
Outdated
| /// literal. | ||
| String _jsonLiteralAsDart(dynamic value, bool asConst) { | ||
| if (value == null) { | ||
| return 'null'; |
There was a problem hiding this comment.
It might read easier if we don't use the else after a return. Also could optionally inline the return
if (value == null) return 'null';
if (value is String) return _jsonStringAsDart(value);
if (value is bool || value is num) {
return value.toString();
}
if (value is List) return _jsonListAsDart(value, asConst);
if (value is Map) return _jsonMapAsDart(value, asConst);
throw ...There was a problem hiding this comment.
I generally like closing braces...but I see your point...
Fix edge cases with String encoding in JsonLiteral generator And add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.