Upgrade to the latest source_gen #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on a git dependency for source_gen until it is published. - Switch to `SharedPartBuilder` to keep using `.g.dart` file extension. - Remove `header` option and documentation since it's not supported with `SharedPartBuilder`. - Update the example to use the latest.
kevmoo
reviewed
Jul 18, 2018
json_serializable/pubspec.yaml
Outdated
| @@ -31,3 +31,7 @@ dev_dependencies: | |||
| dependency_overrides: | |||
| json_annotation: | |||
| path: ../json_annotation | |||
| source_gen: | |||
| git: | |||
| url: git@github.com:dart-lang/source_gen.git | |||
There was a problem hiding this comment.
Must use https://github.com/dart-lang/source_gen to work on travis...
There was a problem hiding this comment.
was planning on updating to point to the published version soon
|
ack
…On Wed, Jul 18, 2018 at 4:26 PM Nate Bosch ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In json_serializable/pubspec.yaml
<#260 (comment)>
:
> @@ -31,3 +31,7 @@ dev_dependencies:
dependency_overrides:
json_annotation:
path: ../json_annotation
+ source_gen:
+ git:
+ url: ***@***.***:dart-lang/source_gen.git
was planning on updating to point to the published version soon
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#260 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCipq_IsythQh6ml0p3EoIC7geprICks5uH8Q7gaJpZM4VVc1S>
.
|
7 tasks
kevmoo
requested changes
Jul 24, 2018
|
...just make sure you clean up the commit log (no example update, etc) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on a git dependency for source_gen until it is published.
SharedPartBuilderto keep using.g.dartfile extension.headeroption and documentation since it's not supported withSharedPartBuilder.