Skip to content

Cleanup #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2017
Merged

Cleanup #25

merged 4 commits into from
Jul 25, 2017

Conversation

kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Jul 24, 2017

No description provided.

@kevmoo kevmoo requested a review from natebosch July 24, 2017 23:07
@@ -11,7 +11,7 @@ class JsonSerializable {
this.createToJson = createToJson;
}

/// Customizes the how an annotated field is serialized
/// Customizes the how an annotated field is serialized.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] prefer a noun phrase.

kevmoo added 4 commits July 25, 2017 09:09
Only generate it once per element and cache it

Mostly to ensure this code path is executed once per field - will make
debugging easier
Was succeeding before by luck
Added items to KitchenSink and Bathtub to help with this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants