Skip to content

Better test - 2 commits #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2018
Merged

Better test - 2 commits #239

merged 2 commits into from
Jun 15, 2018

Conversation

kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Jun 15, 2018

No description provided.

@kevmoo
cleanup(test): centralize CastError matchers
dbb7aa9 
Update to new APIs from pkg:test v0.12.42
@kevmoo kevmoo requested a review from natebosch June 15, 2018 19:44
kevmoo
kevmoo commented Jun 15, 2018
View reviewed changes
json_serializable/test/json_serializable_test.dart Outdated
'todo', (e) => e.todo, todoMatcher),
new FeatureMatcher<InvalidGenerationSourceError>(
'element', (e) => e.element, isNotNull)));
const TypeMatcher<InvalidGenerationSourceError>()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO NICE! @natebosch @jakemac53 @grouma

@kevmoo
cleanup(test): use latest pkg:matcher having goodness
956022a 
Remove unused `FeatureMatcher` class
@kevmoo kevmoo merged commit 956022a into master Jun 15, 2018
@kevmoo kevmoo deleted the better_test branch June 15, 2018 20:15
@Gopinathp Gopinathp mentioned this pull request Jan 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

@natebosch natebosch Awaiting requested review from natebosch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @jakemac53