Run tests on browser #199
Merged
Run tests on browser #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flag tests that cannot run on a browser Fix issues (mostly with numbers) that were different between vm and js Found a bug w/ DDC
jakemac53
reviewed
May 29, 2018
| import 'package:path/path.dart' as p; | ||
|
|
||
| String testFilePath(String part1, [String part2, String part3]) => | ||
| p.join(_packagePath(), part1, part2); |
|
I think you need to add at least: addons:
chrome: stableto the travis.yml for chrome tests |
|
@jakemac53 – green! |
jakemac53
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag tests that cannot run on a browser
Fix issues (mostly with numbers) that were different between vm and js
Found a bug w/ DDC