Skip to content

Use new Analyzer API for resolution. #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2018

Conversation

scheglov
Copy link
Collaborator

We don't have yet API replacement for non-API InheritanceManager, so it is left as is for now.

@scheglov scheglov requested review from kevmoo and bwilkerson May 29, 2018 15:54
@kevmoo
Copy link
Collaborator

kevmoo commented May 29, 2018

@scheglov – does this get us anything?

Copy link

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the code in front of me, but do we need to update the analyzer dependency in pubspec.yaml?

@scheglov
Copy link
Collaborator Author

We already have analyzer ^0.32.0, so we don't need updating it.

@kevmoo We need to move all Analyzer clients to the new API that will work when Analyzer is moved to CFE.

Copy link
Collaborator

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – I'll do the squash!

@kevmoo kevmoo merged commit 74fb024 into google:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants