Fix bug with enum closure parameter #181
Conversation
json_serializable/CHANGELOG.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| ## 0.5.5 | |||
| ## 0.5.4+1 | |||
|
|
|||
| * Added named `formatOutput` parameter to `jsonPartBuilder`. | |||
There was a problem hiding this comment.
adding a parameter (A feature someone can depend on) should be done in a minor release, not a bug fix release. The previous version in this file was better.
There was a problem hiding this comment.
Er, uh. Yup. Will fix.
...although the named arg will be useful to very few people. But fair...
There was a problem hiding this comment.
Went the other way and removed the changelog entry – jsonPartBuilder is not public!
| @@ -34,6 +34,11 @@ class EnumHelper extends TypeHelper { | |||
| var wrappedExpression = | |||
| simpleExpression.hasMatch(expression) ? expression : '{$expression}'; | |||
|
|
|||
| var closureArg = consts.closureArg; | |||
There was a problem hiding this comment.
so was the import unused before? How is it that you could add a prefix without changing any other lines?
There was a problem hiding this comment.
It wasn't unused before. I'm creating a local var that maps exactly to the field closureArg. This way the code that does the generation doesn't change at all...
Remove changelog entry about change to `jsonPartBuilder` – internal API
No description provided.