Validate one-off property sets #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
commented
May 21, 2018
| @@ -237,8 +237,7 @@ Matcher _getMatcher(bool checked, String expectedKey, bool checkedAssignment) { | |||
|
|
|||
| if (checked) { | |||
| if (checkedAssignment && | |||
| const ['intIterable', 'datetime-iterable', 'validatedPropertyNo42'] | |||
| .contains(expectedKey)) { | |||
| const ['intIterable', 'datetime-iterable'].contains(expectedKey)) { | |||
There was a problem hiding this comment.
@jakemac53 – this is where the rubber hits the road. Now the expected key for validatedPropertyNo42 is not null
jakemac53
approved these changes
May 21, 2018
| '${_element.displayName} ${_prefix}FromJson($mapType json) =>' | ||
| '\$checkedNew($classLiteral, json, ()'); | ||
|
|
||
| var data = writeConstructorInvocation( |
There was a problem hiding this comment.
Can this be moved back outside the if? I don't see what is different in the two branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike ctor arguments, we can wrap the entire set of a class property. This allows us to get a the JSON key, even if the error thrown is not an
ArgumentError.