Put custom builders in their own file, enable build_test #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
May 12, 2018
| import 'package:source_gen/source_gen.dart'; | ||
|
|
||
| final _copyrightContent = | ||
| '''// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file |
json_serializable/tool/builder.dart
Outdated
|
|
||
| final copyrightHeader = '$_copyrightContent\n$defaultFileHeader'; | ||
|
|
||
| Builder nonNull(_) => new LibraryBuilder(new _NonNullableGenerator(), |
There was a problem hiding this comment.
consider making the argument optional
Hopefully towards using build.yaml for this package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix one nit in a doc comment in builder.dart