Add support for checked
#151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
force-pushed
the
checked_fun
branch
6 times, most recently
from
72a149f to
b184e1c
Compare
kevmoo
force-pushed
the
checked_fun
branch
2 times, most recently
from
43ce7a1 to
e1367f4
Compare
|
@natebosch @jakemac53 – I split this out into commits that should be easy to consume individually |
jakemac53
approved these changes
May 17, 2018
|
What is |
natebosch
reviewed
May 17, 2018
| /// for large object graphs. | ||
| /// [Map] and [List] instances created during serialization. | ||
| /// | ||
| /// This will increase the code size, but it may improve runtime performance, |
There was a problem hiding this comment.
These line lengths look inconsistent. Would [Map] have fit within 80 characters on line 45 or is this line going over 80 characters?
There was a problem hiding this comment.
I often wrap at the sentence start. It doesn't affect markdown rendering, but it doe make it easier to edit sentences without rewrapping the entire paragraph.
There was a problem hiding this comment.
neither of these lines are wrapped at a sentence start...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.