Skip to content

Validate string literal generation vs "naughty strings" #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2018

Conversation

kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Apr 13, 2018

No description provided.

@kevmoo kevmoo requested a review from natebosch April 13, 2018 05:56
@kevmoo
Copy link
Collaborator Author

kevmoo commented Apr 13, 2018

CC @srawlins – thanks for the inspiration!

@srawlins
Copy link

Haha nice! No new test failures?

@kevmoo
Copy link
Collaborator Author

kevmoo commented Apr 13, 2018

Haha nice! No new test failures?

Thankfully not, but given the complexity of what I'm pulling off, it's nice to have some test cases that I didn't write.

@@ -25,4 +25,15 @@ main() {

expect(dartString, dataString);
});

test('naught strings', () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

"But now...\u001b[20Cfor my greatest trick...\u001b[8m",
"The quic\b\b\b\b\b\bk brown fo\u0007\u0007\u0007\u0007\u0007\u0007\u0007\u0007\u0007\u0007\u0007x... [Beeeep]",
"Powerلُلُصّبُلُلصّبُررً ॣ ॣh ॣ ॣ冗"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Add a newline?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kevmoo kevmoo merged commit cbce271 into master Apr 13, 2018
@kevmoo kevmoo deleted the naughty_strings branch April 13, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants