Skip to content

I big refactor and another integration test #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 30, 2018
Merged

I big refactor and another integration test #123

merged 3 commits into from
Mar 30, 2018

Conversation

kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Mar 30, 2018

No description provided.

kevmoo added 2 commits March 30, 2018 15:04
@kevmoo
Add an integration test for a writeable field w/ @jsonkey(ignore: true)
b8ae6ea
@kevmoo
Refactor generateForAnnotatedElement
85d4570 
Now less than 100 lines
Renamed listFields -> createSortedFieldSet and fixed a subtle bug
Remove duplicate vars (on List, one Map) for the field set
@kevmoo kevmoo requested a review from natebosch March 30, 2018 22:53
@kevmoo kevmoo merged commit 28b6746 into master Mar 30, 2018
@kevmoo kevmoo deleted the more_cleanup branch March 30, 2018 23:01
@Gopinathp Gopinathp mentioned this pull request Jan 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @natebosch