Conversation
kevmoo
force-pushed
the
super_subclasses
branch
from
34fdbbd to
49cf50c
Compare
kevmoo
force-pushed
the
super_subclasses
branch
from
49cf50c to
20ea00b
Compare
natebosch
reviewed
Feb 23, 2018
|
|
||
| /// Returns a list of all instance, [FieldElement] items for [element] and | ||
| /// super classes. | ||
| List<FieldElement> _getFields(ClassElement element) { |
Member
There was a problem hiding this comment.
[optional] I have a personal vendetta against methods named get*. Maybe findFields or allFields?
Collaborator
Author
There was a problem hiding this comment.
Changed to _listFields
| var manager = new InheritanceManager(element.library); | ||
| var things = manager.getMembersInheritedFromClasses(element); | ||
|
|
||
| things.forEach((k, v) { |
Member
There was a problem hiding this comment.
you don't appear to use k at all and this loop has side effects. a for-in loop would be more idiomatic
for(final member in things.values) {
assert(!member.isStatic)
...
}
| var fieldsList = element.fields.where((e) => !e.isStatic).toList(); | ||
|
|
||
| var manager = new InheritanceManager(element.library); | ||
| var things = manager.getMembersInheritedFromClasses(element); |
Member
There was a problem hiding this comment.
things is not descriptive. inheritedMembers maybe, or skip the variable since it's not used more than once.
| var things = manager.getMembersInheritedFromClasses(element); | ||
|
|
||
| things.forEach((k, v) { | ||
| assert(!v.isStatic); |
Member
There was a problem hiding this comment.
are we asserting behavior of getMembersInheritedFromClasses? Do we need to?
natebosch
approved these changes
Feb 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.