Skip to content

example: cleanup #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2018
Merged

example: cleanup #101

merged 3 commits into from
Feb 11, 2018

Conversation

@kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Feb 10, 2018

updated minimum build_runner version - allows $default in build.yaml
Add notes about required SDKs in the readme

@matanlurey
Copy link
Member

matanlurey commented Feb 10, 2018

You need to reduce the lint severity for deprecations:

TASK: dartanalyzer
dartanalyzer --fatal-infos --fatal-warnings .
Analyzing json_serializable...
  hint • 'requireLibraryDirective' is deprecated and shouldn't be used at lib/src/json_part_builder.dart:56:22 • deprecated_member_use
1 hint found.

kevmoo added 3 commits February 9, 2018 19:13
@kevmoo
example: cleanup
dc7d2eb 
updated minimum build_runner version - allows $default in build.yaml
Add notes about required SDKs in the readme
@kevmoo
Ignore deprecated usage of requireLibraryDirective - for now
88cf061
@kevmoo
one-off dartfmt
4fffa5e
@kevmoo kevmoo merged commit 5c4fa3e into master Feb 11, 2018
@kevmoo kevmoo deleted the example_cleanup branch February 11, 2018 01:38
@Gopinathp Gopinathp mentioned this pull request Jan 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakemac53 jakemac53 Awaiting requested review from jakemac53

@natebosch natebosch Awaiting requested review from natebosch

1 more reviewer

@matanlurey matanlurey matanlurey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevmoo @matanlurey