misc: enable and fix a number of lints (#235)

Author: kevmoo

analysis_options.yaml

@@ -2,17 +2,20 @@ analyzer:
   strong-mode:
     implicit-casts: false
   errors:
+    dead_code: error
+    override_on_non_overriding_method: error
     unused_element: error
     unused_import: error
     unused_local_variable: error
-    dead_code: error
 linter:
   rules:
+    - always_declare_return_types
     - annotate_overrides
     - avoid_empty_else
     - avoid_function_literals_in_foreach_calls
     - avoid_init_to_null
     - avoid_null_checks_in_equality_operators
+    - avoid_renaming_method_parameters
     - avoid_return_types_on_setters
     - avoid_returning_null
     - avoid_types_as_parameter_names
@@ -35,6 +38,7 @@ linter:
     - library_names
     - library_prefixes
     - list_remove_unrelated_type
+    - literal_only_boolean_expressions
     - no_adjacent_strings_in_list
     - no_duplicate_case_values
     - non_constant_identifier_names
@@ -49,6 +53,7 @@ linter:
     - prefer_conditional_assignment
     - prefer_const_constructors
     - prefer_contains
+    - prefer_equal_for_default_values
     - prefer_final_fields
     - prefer_initializing_formals
     - prefer_interpolation_to_compose_strings
@@ -70,4 +75,5 @@ linter:
     - unnecessary_statements
     - unnecessary_this
     - unrelated_type_equality_checks
+    - use_rethrow_when_possible
     - valid_regexps

json_annotation/lib/src/json_literal.dart

@@ -24,6 +24,6 @@ class JsonLiteral {
   final bool asConst;
 
   /// Creates a new [JsonLiteral] instance.
-  const JsonLiteral(this.path, {bool asConst: false})
+  const JsonLiteral(this.path, {bool asConst = false})
       : this.asConst = asConst ?? false;
 }

json_annotation/lib/src/json_serializable.dart

@@ -74,11 +74,11 @@ class JsonSerializable {
 
   /// Creates a new [JsonSerializable] instance.
   const JsonSerializable({
-    bool disallowUnrecognizedKeys: false,
-    bool createFactory: true,
-    bool createToJson: true,
-    bool includeIfNull: true,
-    bool nullable: true,
+    bool disallowUnrecognizedKeys = false,
+    bool createFactory = true,
+    bool createToJson = true,
+    bool includeIfNull = true,
+    bool nullable = true,
   })  : this.disallowUnrecognizedKeys = disallowUnrecognizedKeys ?? false,
         this.createFactory = createFactory ?? true,
         this.createToJson = createToJson ?? true,

json_serializable/lib/src/json_part_builder.dart

@@ -23,11 +23,11 @@ import 'json_serializable_generator.dart';
 Builder jsonPartBuilder({
   String header,
   String formatOutput(String code),
-  bool useWrappers: false,
-  bool anyMap: false,
-  bool checked: false,
-  bool explicitToJson: false,
-  bool generateToJsonFunction: false,
+  bool useWrappers = false,
+  bool anyMap = false,
+  bool checked = false,
+  bool explicitToJson = false,
+  bool generateToJsonFunction = false,
 }) {
   return new PartBuilder([
     new JsonSerializableGenerator(

json_serializable/lib/src/json_serializable_generator.dart

@@ -5,6 +5,7 @@
 import 'dart:async';
 
 import 'package:analyzer/dart/element/element.dart';
+import 'package:build/build.dart';
 
 import 'package:json_annotation/json_annotation.dart';
 import 'package:source_gen/source_gen.dart';
@@ -121,11 +122,11 @@ class JsonSerializableGenerator
   /// [JsonHelper], [DateTimeHelper], and [UriHelper].
   const JsonSerializableGenerator({
     List<TypeHelper> typeHelpers,
-    bool useWrappers: false,
-    bool anyMap: false,
-    bool checked: false,
-    bool explicitToJson: false,
-    bool generateToJsonFunction: false,
+    bool useWrappers = false,
+    bool anyMap = false,
+    bool checked = false,
+    bool explicitToJson = false,
+    bool generateToJsonFunction = false,
   })  : this.useWrappers = useWrappers ?? false,
         this.anyMap = anyMap ?? false,
         this.checked = checked ?? false,
@@ -140,10 +141,10 @@ class JsonSerializableGenerator
   /// [JsonHelper], [DateTimeHelper], and [UriHelper].
   factory JsonSerializableGenerator.withDefaultHelpers(
     Iterable<TypeHelper> typeHelpers, {
-    bool useWrappers: false,
-    bool anyMap: false,
-    bool checked: false,
-    bool generateToJsonFunction: false,
+    bool useWrappers = false,
+    bool anyMap = false,
+    bool checked = false,
+    bool generateToJsonFunction = false,
   }) =>
       new JsonSerializableGenerator(
           useWrappers: useWrappers,
@@ -155,6 +156,6 @@ class JsonSerializableGenerator
 
   @override
   Future<String> generateForAnnotatedElement(
-          Element element, ConstantReader annotation, _) =>
+          Element element, ConstantReader annotation, BuildStep buildStep) =>
       generate(this, element, annotation);
 }

json_serializable/lib/src/type_helpers/value_helper.dart

@@ -12,7 +12,8 @@ class ValueHelper extends TypeHelper {
   const ValueHelper();
 
   @override
-  String serialize(DartType targetType, String expression, _) {
+  String serialize(
+      DartType targetType, String expression, SerializeContext context) {
     if (targetType.isDynamic ||
         targetType.isObject ||
         simpleJsonTypeChecker.isAssignableFromType(targetType)) {

json_serializable/test/integration/integration_test.dart

@@ -10,7 +10,7 @@ import 'json_test_example.dart';
 
 void main() {
   group('Person', () {
-    roundTripPerson(Person p) {
+    void roundTripPerson(Person p) {
       roundTripObject(p, (json) => new Person.fromJson(json));
     }
 
@@ -49,7 +49,7 @@ void main() {
   });
 
   group('Order', () {
-    roundTripOrder(Order p) {
+    void roundTripOrder(Order p) {
       roundTripObject(p, (json) => new Order.fromJson(json));
     }
 
@@ -116,7 +116,7 @@ void main() {
   });
 
   group('Item', () {
-    roundTripItem(Item p) {
+    void roundTripItem(Item p) {
       roundTripObject(p, (json) => new Item.fromJson(json));
     }
 
@@ -141,7 +141,7 @@ void main() {
   });
 
   group('Numbers', () {
-    roundTripNumber(Numbers p) {
+    void roundTripNumber(Numbers p) {
       roundTripObject(p, (json) => new Numbers.fromJson(json));
     }
 

json_serializable/test/kitchen_sink/kitchen_sink_test.dart

@@ -79,7 +79,7 @@ typedef KitchenSink KitchenSinkCtor(
     Iterable<DateTime> dateTimeIterable});
 
 void _nonNullableTests(KitchenSinkCtor ctor, KitchenSink fromJson(Map json),
-    {bool isChecked: false}) {
+    {bool isChecked = false}) {
   test('with null values fails serialization', () {
     expect(() => (ctor()..objectDateTimeMap = null).toJson(),
         throwsNoSuchMethodError);
@@ -150,7 +150,7 @@ void _nullableTests(KitchenSinkCtor ctor, KitchenSink fromJson(Map json)) {
 }
 
 void _sharedTests(KitchenSinkCtor ctor, KitchenSink fromJson(Map json),
-    {bool isChecked: false}) {
+    {bool isChecked = false}) {
   void roundTripSink(KitchenSink p) {
     roundTripObject(p, fromJson);
   }

json_serializable/test/literal/json_literal_test.dart

@@ -13,7 +13,7 @@ import '../test_file_utils.dart';
 import '../test_utils.dart';
 import 'json_literal.dart';
 
-main() {
+void main() {
   test('literal round-trip', () {
     var dataFilePath = testFilePath('test', 'literal', 'json_literal.json');
     var dataFile = new File(dataFilePath);

json_serializable/test/src/json_serializable_test_input.dart

@@ -60,7 +60,7 @@ class FromJsonOptionalParameters {
 }
 
 class ChildWithFromJson {
-  ChildWithFromJson.fromJson(json, {initValue: false});
+  ChildWithFromJson.fromJson(json, {initValue = false});
 }
 
 @JsonSerializable()

json_serializable/test/test_utils.dart

@@ -16,7 +16,7 @@ class FeatureMatcher<T> extends CustomMatcher {
       : super('`$name`', '`$name`', matcher);
 
   @override
-  featureValueOf(covariant T actual) => _feature(actual);
+  Object featureValueOf(covariant T actual) => _feature(actual);
 }
 
 T roundTripObject<T>(T object, T factory(Map<String, dynamic> json)) {

json_serializable/tool/build.dart

@@ -118,6 +118,6 @@ final List<BuilderApplication> builders = [
       hideOutput: true),
 ];
 
-main(List<String> args) async {
+void main(List<String> args) async {
   exitCode = await run(args, builders);
 }