Make some things illegal

Author: kevmoo

lib/src/json_serializable_generator.dart

@@ -111,8 +111,14 @@ class JsonSerializableGenerator
 
       var pairs = <String>[];
       fields.forEach((fieldName, field) {
-        pairs.add("'${_fieldToJsonMapKey(fieldName, field)}': "
-            "${_fieldToJsonMapValue(fieldName, field.type)}");
+        try {
+          pairs.add("'${_fieldToJsonMapKey(fieldName, field)}': "
+              "${_fieldToJsonMapValue(fieldName, field.type)}");
+        } on _UnsupportedTypeError {
+          throw new InvalidGenerationSourceError(
+              "Could not generate `toJson` code for `${friendlyNameForElement(field)}`.",
+              todo: "Make sure all of the types are serializable.");
+        }
       });
       buffer.writeln(pairs.join(','));
 
@@ -246,7 +252,7 @@ class JsonSerializableGenerator
       return _mapFieldToJsonMapValue(expression, fieldType, depth);
     }
 
-    return "$expression /* unsafe */";
+    throw new _UnsupportedTypeError(fieldType, expression);
   }
 
   String _listFieldToJsonMapValue(
@@ -314,7 +320,7 @@ class JsonSerializableGenerator
           "$expression.keys,"
           "$expression.values.map(($substitute) => $subFieldValue))";
     }
-    return "$expression /* unsafe */";
+    throw new _UnsupportedTypeError(fieldType, expression);
   }
 
   String _jsonMapAccessToField(String name, FieldElement field,
@@ -323,7 +329,14 @@ class JsonSerializableGenerator
     var result = "json['$name']";
 
     var targetType = ctorParam?.type ?? field.type;
-    return _writeAccessToJsonValue(result, targetType);
+
+    try {
+      return _writeAccessToJsonValue(result, targetType);
+    } on _UnsupportedTypeError {
+      throw new InvalidGenerationSourceError(
+          "Could not generate fromJson code for `${friendlyNameForElement(field)}`.",
+          todo: "Make sure all of the types are serializable.");
+    }
   }
 
   String _writeAccessToJsonValue(String varExpression, DartType searchType,
@@ -370,7 +383,7 @@ class JsonSerializableGenerator
           _coreStringChecker.isExactlyType(keyArg);
 
       if (!safeKey) {
-        return "$varExpression /* unsafe key type */";
+        throw new _UnsupportedTypeError(keyArg, varExpression);
       }
 
       // this is the trivial case. Do a runtime cast to the known type of JSON
@@ -403,7 +416,7 @@ class JsonSerializableGenerator
       return "$varExpression as $searchType";
     }
 
-    return "$varExpression /* unsafe */";
+    throw new _UnsupportedTypeError(searchType, varExpression);
   }
 }
 
@@ -464,3 +477,10 @@ final _stringBoolNumChecker = new TypeChecker.any([
   new TypeChecker.fromUrl('dart:core#bool'),
   new TypeChecker.fromUrl('dart:core#num')
 ]);
+
+class _UnsupportedTypeError extends Error {
+  final String expression;
+  final DartType type;
+
+  _UnsupportedTypeError(this.type, this.expression);
+}

test/json_serializable_integration_test.dart

@@ -111,13 +111,10 @@ void main() {
         'objectList',
         'intList',
         'dateTimeList',
-        'stopWatch',
-        'stopwatchList',
         'map',
         'stringStringMap',
         'stringIntMap',
-        'stringDateTimeMap',
-        'intDateTimeMap'
+        'stringDateTimeMap'
       ];
 
       expect(json.keys, orderedEquals(expectedOrder));

test/json_serializable_test.dart

@@ -63,6 +63,48 @@ void main() {
     });
   });
 
+  group('unserializable types', () {
+    test('for toJson', () async {
+      var element = await _getClassForCodeString('NoSerializeFieldType');
+
+      expect(
+          _generator.generate(element, null),
+          throwsInvalidGenerationSourceError(
+              'Could not generate `toJson` code for `Stopwatch watch`.',
+              'Make sure all of the types are serializable.'));
+    });
+
+    test('for fromJson', () async {
+      var element = await _getClassForCodeString('NoDeserializeFieldType');
+
+      expect(
+          _generator.generate(element, null),
+          throwsInvalidGenerationSourceError(
+              'Could not generate fromJson code for `Stopwatch watch`.',
+              'Make sure all of the types are serializable.'));
+    });
+
+    test('for toJson in Map key', () async {
+      var element = await _getClassForCodeString('NoSerializeBadKey');
+
+      expect(
+          _generator.generate(element, null),
+          throwsInvalidGenerationSourceError(
+              'Could not generate `toJson` code for `Map<int, DateTime> intDateTimeMap`.',
+              'Make sure all of the types are serializable.'));
+    });
+
+    test('for fromJson', () async {
+      var element = await _getClassForCodeString('NoDeserializeBadKey');
+
+      expect(
+          _generator.generate(element, null),
+          throwsInvalidGenerationSourceError(
+              'Could not generate fromJson code for `Map<int, DateTime> intDateTimeMap`.',
+              'Make sure all of the types are serializable.'));
+    });
+  });
+
   test('class with final fields', () async {
     var element = await _getClassForCodeString('FinalFields');
     var generateResult = await _generator.generate(element, null);
@@ -234,13 +276,33 @@ class ParentObjectWithDynamicChildren {
 
 @JsonSerializable()
 class UnknownCtorParamType {
-  int number
+  int number;
   
   UnknownCtorParamType(Bob number) : this.number = number;
 }
 
 @JsonSerializable()
 class UnknownFieldType {
-  Bob number
+  Bob number;
+}
+
+@JsonSerializable(createFactory: false)
+class NoSerializeFieldType {
+  Stopwatch watch;
+}
+
+@JsonSerializable(createToJson: false)
+class NoDeserializeFieldType {
+  Stopwatch watch;
+}
+
+@JsonSerializable(createFactory: false)
+class NoSerializeBadKey {
+  Map<int, DateTime> intDateTimeMap;
+}
+
+@JsonSerializable(createToJson: false)
+class NoDeserializeBadKey {
+  Map<int, DateTime> intDateTimeMap;
 }
 ''';

test/test_files/json_test_example.dart

@@ -53,20 +53,11 @@ class KitchenSink extends Object with _$KitchenSinkSerializerMixin {
   List<int> intList;
   List<DateTime> dateTimeList;
 
-  /// Intentionally unsafe
-  Stopwatch stopWatch;
-
-  /// Intentionally unsafe
-  List<Stopwatch> stopwatchList;
-
   Map map;
   Map<String, String> stringStringMap;
   Map<String, int> stringIntMap;
   Map<String, DateTime> stringDateTimeMap;
 
-  // Intentionally unsafe key
-  Map<int, DateTime> intDateTimeMap;
-
   //TODO(kevmoo) - finish this...
   bool operator ==(Object other) =>
       other is KitchenSink &&