enable and fix some lints

Author: kevmoo

analysis_options.yaml

@@ -37,6 +37,7 @@ linter:
     - implementation_imports
     - invariant_booleans
     - iterable_contains_unrelated_type
+    - join_return_with_assignment
     - library_names
     - library_prefixes
     - list_remove_unrelated_type
@@ -69,6 +70,7 @@ linter:
     - prefer_typing_uninitialized_variables
     - recursive_getters
     - slash_for_doc_comments
+    - sort_pub_dependencies
     - test_types_in_equals
     - throw_in_finally
     - type_init_formals
@@ -79,6 +81,7 @@ linter:
     - unnecessary_lambdas
     - unnecessary_new
     - unnecessary_null_aware_assignments
+    - unnecessary_parenthesis
     - unnecessary_statements
     - unnecessary_this
     - unrelated_type_equality_checks

json_serializable/lib/src/json_key_utils.dart

@@ -163,7 +163,7 @@ JsonKey _populateJsonKey(
     includeIfNull = false;
   }
 
-  final jsonKey = JsonKey(
+  return JsonKey(
     defaultValue: defaultValue,
     disallowNullValue: disallowNullValue ?? false,
     ignore: ignore ?? false,
@@ -174,8 +174,6 @@ JsonKey _populateJsonKey(
     required: required ?? false,
     encodeEmptyCollection: encodeEmptyCollection,
   );
-
-  return jsonKey;
 }
 
 String _encodedFieldName(JsonSerializable classAnnotation,

json_serializable/test/config_test.dart

@@ -115,7 +115,7 @@ void main() {
             : "type 'int' is not a subtype of type 'bool' in type cast";
 
         final matcher = isA<StateError>().having(
-          ((v) => v.message),
+          (v) => v.message,
           'message',
           '''
 Could not parse the options provided for `json_serializable`.

json_serializable/tool/test_builder.dart

@@ -279,8 +279,6 @@ class _Replacement {
       }
     }
 
-    outputContent = outputContent.replaceAll(',)', ',\n)');
-
-    return outputContent;
+    return outputContent.replaceAll(',)', ',\n)');
   }
 }