Removed deprecated support for require_library_directive

...and support the latest `package:source_gen`.

Author: kevmoo

json_serializable/CHANGELOG.md

@@ -1,4 +1,9 @@
-## 0.4.1
+## 0.5.0
+
+* **BREAKING** Removed deprecated support for `require_library_directive` /
+  `requireLibraryDirective` in `build_runner` configuration.
+
+* Support the latest `package:source_gen`.
 
 * Private and ignored fields are now excluded when generating serialization and
   deserialization code by using `@JsonKey(ignore: true)`.

json_serializable/lib/builder.dart

@@ -3,12 +3,28 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:build/build.dart';
+import 'package:logging/logging.dart';
 
 import 'json_serializable.dart';
 
-Builder jsonSerializable(BuilderOptions options) => jsonPartBuilder(
-    header: options.config['header'] as String,
-    useWrappers: options.config['use_wrappers'] as bool ?? false,
-    // ignore: deprecated_member_use
-    requireLibraryDirective:
-        options.config['require_library_directive'] as bool ?? false);
+// TODO: until we can use `log` here - github.com/dart-lang/build/issues/1223
+final _logger = new Logger('json_serializable');
+
+/// Supports `package:build_runner` creation and configuration of `build_cli`.
+///
+/// Not meant to be invoked by hand-authored code.
+Builder jsonSerializable(BuilderOptions options) {
+  // Paranoid copy of options.config - don't assume it's mutable or needed
+  // elsewhere.
+  var optionsMap = new Map<String, dynamic>.from(options.config);
+
+  try {
+    return jsonPartBuilder(
+        header: optionsMap.remove('header') as String,
+        useWrappers: optionsMap.remove('use_wrappers') as bool);
+  } finally {
+    if (optionsMap.isNotEmpty) {
+      _logger.warning('These options were ignored: `$optionsMap`.');
+    }
+  }
+}

json_serializable/lib/src/json_part_builder.dart

@@ -5,9 +5,6 @@
 // https://github.com/dart-lang/sdk/issues/31761
 // ignore_for_file: comment_references
 
-// Until `requireLibraryDirective` is removed
-// ignore_for_file: deprecated_member_use
-
 import 'package:build/build.dart';
 import 'package:source_gen/source_gen.dart';
 
@@ -26,15 +23,6 @@ import 'json_serializable_generator.dart';
 /// increase the code size, but it may improve runtime performance, especially
 /// for large object graphs.
 ///
-/// May set [requireLibraryDirective] to `true` in order to opt-out of the
-/// Dart `2.0.0-dev` feature of `part of` being usable without an explicit
-/// `library` directive. Developers should restrict the SDK constraint in
-/// `pubspec.yaml` accordingly:
-///
-/// ```yaml
-/// sdk: '>=2.0.0-dev <2.0.0'
-/// ```
-///
 /// Usage:
 ///
 /// ```dart
@@ -49,20 +37,10 @@ import 'json_serializable_generator.dart';
 /// `json_serializable`.
 ///
 /// [example]: https://github.com/dart-lang/json_serializable/tree/master/example
-Builder jsonPartBuilder(
-    {String header,
-    bool useWrappers: false,
-    @Deprecated(
-        'Library directives are no longer required for part generation. '
-        'This option will be removed in v0.4.0.')
-        bool requireLibraryDirective: false}) {
+Builder jsonPartBuilder({String header, bool useWrappers: false}) {
   useWrappers ??= false;
-  requireLibraryDirective ??= false;
   return new PartBuilder([
     new JsonSerializableGenerator(useWrappers: useWrappers),
     const JsonLiteralGenerator()
-  ],
-      header: header,
-      // ignore: deprecated_member_use
-      requireLibraryDirective: requireLibraryDirective);
+  ], header: header);
 }

json_serializable/lib/src/utils.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'dart:io';
 import 'package:analyzer/dart/element/element.dart';
 
 // Copied from pkg/source_gen - lib/src/utils.
@@ -39,10 +38,5 @@ String friendlyNameForElement(Element element) {
   return names.join(' ');
 }
 
-/// Logs to STDERR with wrapper stars to make things readable during build.
-void log(object) {
-  stderr.writeln(['***', object, '***'].join('\n'));
-}
-
 final toJsonMapVarName = 'val';
 final toJsonMapHelperName = 'writeNotNull';

json_serializable/pubspec.yaml

@@ -1,5 +1,5 @@
 name: json_serializable
-version: 0.4.1-dev
+version: 0.5.0-dev
 author: Dart Team <misc@dartlang.org>
 description: Generates utilities to aid in serializing to/from JSON.
 homepage: https://github.com/dart-lang/json_serializable
@@ -15,7 +15,7 @@ dependencies:
   # `json_annotation`. Properly constrains all features it provides.
   json_annotation: '>=0.2.3 <0.2.4'
   path: ^1.3.2
-  source_gen: ^0.7.5
+  source_gen: '>=0.7.5 <0.9.0'
 dev_dependencies:
   build_runner: ^0.8.0
   build_test: ">=0.9.0 <0.11.0"