Skip to content

#55 Update Gradle to 8.4 and replace unmaintained plugin with Spotless plugin #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SingingBush
Copy link

this PR contains the following:

  • Update gradle wrapper to 8.4 (requires numerous changes to gradle build files)
  • Replace google-java-format with com.diffplug.spotless (which supports google-java-format as well)
  • Add GitHub action to ensure builds with both JDK 11 and 17 (21 will require Gradle 9)
  • Add Automatic-Module-Name to the manifest for photoslibraryapi

@SingingBush
Copy link
Author

Is this project still maintained?

@chrisachard
Copy link
Member

Since there has been the recent announcement of the new Picker API (https://developers.googleblog.com/en/google-photos-picker-api-launch-and-library-api-updates/) this library will be undergoing changes. We anticipate those changes to be available in another branch later this year, then those will be merged into the main branch on March 31, 2025.

@SingingBush
Copy link
Author

ok thanks for the link. I was not aware of the Picker API. Any chance of the new work being JDK 11+ and having full JPMS support via module-info.java

@chrisachard
Copy link
Member

I'm not sure, but I'll keep it mind as the library gets updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants