Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version flag #179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

romainmenke
Copy link

@romainmenke romainmenke commented Apr 6, 2017

Added a version flag to the cli.

Currently prints : Guetzli 1.0.1

#130

@gtuk
Copy link

gtuk commented Apr 6, 2017

@romainmenke Maybe another/better solution is to create a header file dynamicly on the built process to read the version and maybe add the commit hash from another file, like other/popular tools do it, sothat its not required to edit the guetzli.cc on every version change

@romainmenke
Copy link
Author

@gtuk c++ is not my strong suit, thought I would get the ball rolling by adding the flag to the cli already. Do you have a reference for the method you describe?

@gtuk
Copy link

gtuk commented Apr 6, 2017

@romainmenke i had something like this http://stackoverflow.com/a/1843783 or this http://m.linuxjournal.com/content/add-auto-incrementing-build-number-your-build-process in mind. Maybe its a good first reference. Let me know if i can help you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants