google#1409 Add poll() and offer() to Uninterruptibles class

[tanmayvarun]

No description provided.

[tanmayvarun]

Any updates?

[cpovirk]

I still probably won't have a chance for a while, but it's on my to-do list.

[tanmayvarun]

I still probably won't have a chance for a while, but it's on my to-do list.

Works bro, I don't have slightest clue how full is your plate 👍

[tanmayvarun]

@cpovirk Can you please review and possibly close this!

[cpovirk]

It's still on my list, just still behind some other things :(

[tanmayvarun]

@cpovirk Sorry again, I was waiting for my first PR accepted, that has happened so I am fine!

Please suggest some feature development problems to work on..

[cpovirk]

Sorry for the delay on the other one, which was simple enough that I should have accepted it more quickly.

I'll let you know if I think of some more ideas.

[tanmayvarun]

Sure Ack.

[tanmayvarun]

Sorry for the delay on the other one, which was simple enough that I should have accepted it more quickly.

I'll let you know if I think of some more ideas.

@cpovirk any issues/features you suggest?

[cpovirk]

The one thing that comes to mind is a Dependabot config (like this one) for https://github.com/google/caliper. But before doing that, we'd really like to update all our dependencies (mvn org.codehaus.mojo:versions-maven-plugin:2.8.1:update-properties org.codehaus.mojo:versions-maven-plugin:2.8.1:use-latest-releases, similar to this commit) and all our plugins (which may be easiest to do by hand).

[cpovirk]

Also #3679

[tanmayvarun]

@cpovirk Sure will take up #3679 first as it seems quick fix.

[cpovirk]

Sorry for taking so long on this. The main thing that these implementations will need to do is to track how much time has passed. Currently, they always pass the original timeout to the delegate. But when that call is interrupted, they should pass only how much time is left. You can see how to set that up here;

guava/android/guava/src/com/google/common/util/concurrent/Uninterruptibles.java

Line 81 in ce71b12

long remainingNanos = unit.toNanos(timeout);

[tanmayvarun]

@cpovirk I have updated offer, poll functions adding timeout update as required. Please check.