Skip to content

Commit f9a29d7

Browse files
cpovirkGoogle Java Core Libraries
authored andcommitted
Merge nested try-catch blocks.
Fixes #6599 RELNOTES=n/a PiperOrigin-RevId: 543735962
1 parent 641d9e6 commit f9a29d7

File tree

2 files changed

+18
-24
lines changed

2 files changed

+18
-24
lines changed

android/guava/src/com/google/common/util/concurrent/SimpleTimeLimiter.java

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
import static com.google.common.base.Preconditions.checkArgument;
1818
import static com.google.common.base.Preconditions.checkNotNull;
19+
import static com.google.common.util.concurrent.Uninterruptibles.getUninterruptibly;
1920

2021
import com.google.common.annotations.GwtIncompatible;
2122
import com.google.common.annotations.J2ktIncompatible;
@@ -122,16 +123,12 @@ private static <T> T newProxy(Class<T> interfaceType, InvocationHandler handler)
122123
Future<T> future = executor.submit(callable);
123124

124125
try {
125-
if (amInterruptible) {
126-
try {
127-
return future.get(timeoutDuration, timeoutUnit);
128-
} catch (InterruptedException e) {
129-
future.cancel(true);
130-
throw e;
131-
}
132-
} else {
133-
return Uninterruptibles.getUninterruptibly(future, timeoutDuration, timeoutUnit);
134-
}
126+
return amInterruptible
127+
? future.get(timeoutDuration, timeoutUnit)
128+
: getUninterruptibly(future, timeoutDuration, timeoutUnit);
129+
} catch (InterruptedException e) {
130+
future.cancel(true);
131+
throw e;
135132
} catch (ExecutionException e) {
136133
throw throwCause(e, true /* combineStackTraces */);
137134
} catch (TimeoutException e) {
@@ -176,7 +173,7 @@ private static <T> T newProxy(Class<T> interfaceType, InvocationHandler handler)
176173
Future<T> future = executor.submit(callable);
177174

178175
try {
179-
return Uninterruptibles.getUninterruptibly(future, timeoutDuration, timeoutUnit);
176+
return getUninterruptibly(future, timeoutDuration, timeoutUnit);
180177
} catch (TimeoutException e) {
181178
future.cancel(true /* mayInterruptIfRunning */);
182179
throw e;
@@ -216,7 +213,7 @@ public void runUninterruptiblyWithTimeout(
216213
Future<?> future = executor.submit(runnable);
217214

218215
try {
219-
Uninterruptibles.getUninterruptibly(future, timeoutDuration, timeoutUnit);
216+
getUninterruptibly(future, timeoutDuration, timeoutUnit);
220217
} catch (TimeoutException e) {
221218
future.cancel(true /* mayInterruptIfRunning */);
222219
throw e;

guava/src/com/google/common/util/concurrent/SimpleTimeLimiter.java

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
import static com.google.common.base.Preconditions.checkArgument;
1818
import static com.google.common.base.Preconditions.checkNotNull;
19+
import static com.google.common.util.concurrent.Uninterruptibles.getUninterruptibly;
1920

2021
import com.google.common.annotations.GwtIncompatible;
2122
import com.google.common.annotations.J2ktIncompatible;
@@ -122,16 +123,12 @@ private static <T> T newProxy(Class<T> interfaceType, InvocationHandler handler)
122123
Future<T> future = executor.submit(callable);
123124

124125
try {
125-
if (amInterruptible) {
126-
try {
127-
return future.get(timeoutDuration, timeoutUnit);
128-
} catch (InterruptedException e) {
129-
future.cancel(true);
130-
throw e;
131-
}
132-
} else {
133-
return Uninterruptibles.getUninterruptibly(future, timeoutDuration, timeoutUnit);
134-
}
126+
return amInterruptible
127+
? future.get(timeoutDuration, timeoutUnit)
128+
: getUninterruptibly(future, timeoutDuration, timeoutUnit);
129+
} catch (InterruptedException e) {
130+
future.cancel(true);
131+
throw e;
135132
} catch (ExecutionException e) {
136133
throw throwCause(e, true /* combineStackTraces */);
137134
} catch (TimeoutException e) {
@@ -176,7 +173,7 @@ private static <T> T newProxy(Class<T> interfaceType, InvocationHandler handler)
176173
Future<T> future = executor.submit(callable);
177174

178175
try {
179-
return Uninterruptibles.getUninterruptibly(future, timeoutDuration, timeoutUnit);
176+
return getUninterruptibly(future, timeoutDuration, timeoutUnit);
180177
} catch (TimeoutException e) {
181178
future.cancel(true /* mayInterruptIfRunning */);
182179
throw e;
@@ -216,7 +213,7 @@ public void runUninterruptiblyWithTimeout(
216213
Future<?> future = executor.submit(runnable);
217214

218215
try {
219-
Uninterruptibles.getUninterruptibly(future, timeoutDuration, timeoutUnit);
216+
getUninterruptibly(future, timeoutDuration, timeoutUnit);
220217
} catch (TimeoutException e) {
221218
future.cancel(true /* mayInterruptIfRunning */);
222219
throw e;

0 commit comments

Comments
 (0)