Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backoff from using commitlint #8

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Aug 3, 2017

  • unwelcoming for new contributors
  • doesn't cover the case where the commits are adjusted/squashed at landing time on GitHub

* unwelcoming for new contributors
* doesn't cover the case where the commits are adjusted/squashed at landing time on GitHub
@JustinBeckwith
Copy link
Collaborator

LGTM. Thanks for this :) For maintainers, is there a simple way to update commit messages as we wish?

@ofrobots
Copy link
Contributor Author

ofrobots commented Aug 3, 2017

Commit messages can be edited at landing time in the GitHub UI when using the 'squash and merge' button.

@ofrobots ofrobots merged commit dd37aa0 into google:master Aug 3, 2017
@ofrobots ofrobots deleted the commitlint branch August 3, 2017 16:21
@marionebl
Copy link

marionebl commented Oct 14, 2017

Sorry to read commitlint did not match your use case. Paul Irish recently started work on https://github.com/paulirish/commitlintbot. Have not tried it myself but it looks as if this could solve the Squash/Merge problem.


Edit: I am collecting ideas on how to improve the contributor experience over at https://github.com/marionebl/commitlint/issues/94. Feedback there would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants