Skip to content

Commit c58f562

Browse files
derekmaurocopybara-github
authored andcommitted
Makes the Python imports consistently use full paths from the repository root,
unifying the behavior between Bazel and CMake This fixes one of the CI failures on Windows PiperOrigin-RevId: 417872531 Change-Id: I156989323b7e6d4a4420f4f9691b078829db933d
1 parent 71d4e2f commit c58f562

29 files changed

+34
-44
lines changed

googlemock/test/gmock_leak_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232
"""Tests that leaked mock objects can be caught be Google Mock."""
3333

34-
import gmock_test_utils
34+
from googlemock.test import gmock_test_utils
3535

3636
PROGRAM_PATH = gmock_test_utils.GetTestExecutablePath('gmock_leak_test_')
3737
TEST_WITH_EXPECT_CALL = [PROGRAM_PATH, '--gtest_filter=*ExpectCall*']

googlemock/test/gmock_output_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
import os
4444
import re
4545
import sys
46-
import gmock_test_utils
46+
from googlemock.test import gmock_test_utils
4747

4848

4949
# The flag for generating the golden file

googlemock/test/gmock_test_utils.py

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,21 +30,9 @@
3030
"""Unit test utilities for Google C++ Mocking Framework."""
3131

3232
import os
33-
import sys
34-
35-
# Determines path to gtest_test_utils and imports it.
36-
SCRIPT_DIR = os.path.dirname(__file__) or '.'
37-
38-
# isdir resolves symbolic links.
39-
gtest_tests_util_dir = os.path.join(SCRIPT_DIR, '../../googletest/test')
40-
if os.path.isdir(gtest_tests_util_dir):
41-
GTEST_TESTS_UTIL_DIR = gtest_tests_util_dir
42-
else:
43-
GTEST_TESTS_UTIL_DIR = os.path.join(SCRIPT_DIR, '../../googletest/test')
44-
sys.path.append(GTEST_TESTS_UTIL_DIR)
4533

4634
# pylint: disable=C6204
47-
import gtest_test_utils
35+
from googletest.test import gtest_test_utils
4836

4937

5038
def GetSourceDir():

googletest/cmake/internal_utils.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,8 @@ function(py_test name)
304304
COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/test/${name}.py
305305
--build_dir=${CMAKE_CURRENT_BINARY_DIR}/\${CTEST_CONFIGURATION_TYPE} ${ARGN})
306306
endif()
307+
# Make the Python import path consistent between Bazel and CMake.
308+
set_tests_properties(${name} PROPERTIES ENVIRONMENT PYTHONPATH=${CMAKE_SOURCE_DIR})
307309
endif(PYTHONINTERP_FOUND)
308310
endfunction()
309311

googletest/test/googletest-break-on-failure-unittest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"""
4040

4141
import os
42-
import gtest_test_utils
42+
from googletest.test import gtest_test_utils
4343

4444
# Constants.
4545

googletest/test/googletest-catch-exceptions-test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
Google Test) and verifies their output.
3636
"""
3737

38-
import gtest_test_utils
38+
from googletest.test import gtest_test_utils
3939

4040
# Constants.
4141
FLAG_PREFIX = '--gtest_'

googletest/test/googletest-color-test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"""Verifies that Google Test correctly determines whether to use colors."""
3333

3434
import os
35-
import gtest_test_utils
35+
from googletest.test import gtest_test_utils
3636

3737
IS_WINDOWS = os.name == 'nt'
3838

googletest/test/googletest-env-var-test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"""Verifies that Google Test correctly parses environment variables."""
3333

3434
import os
35-
import gtest_test_utils
35+
from googletest.test import gtest_test_utils
3636

3737

3838
IS_WINDOWS = os.name == 'nt'

googletest/test/googletest-failfast-unittest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"""
4242

4343
import os
44-
import gtest_test_utils
44+
from googletest.test import gtest_test_utils
4545

4646
# Constants.
4747

googletest/test/googletest-filter-unittest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
except ImportError:
4848
pass
4949
import sys
50-
import gtest_test_utils
50+
from googletest.test import gtest_test_utils
5151

5252
# Constants.
5353

0 commit comments

Comments
 (0)